Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 795993002: Introduce unsigned representation types (Closed)

Created:
6 years ago by rossberg
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
Jarin, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Introduce unsigned representation types To make space in the type bitset, remove Function, RegExp, and Buffer types for now, since they aren't really relied upon anyway. R=bmeurer@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -79 lines) Patch
M src/compiler/access-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 9 chunks +22 lines, -20 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/types.h View 3 chunks +40 lines, -34 lines 0 comments Download
M src/types.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/typing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-types.cc View 7 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rossberg
6 years ago (2014-12-11 13:01:43 UTC) #1
Benedikt Meurer
lgtm
6 years ago (2014-12-11 13:20:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795993002/1
6 years ago (2014-12-11 13:21:11 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-11 13:47:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698