Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6332)

Unified Diff: chrome/browser/ui/browser.h

Issue 795943002: Fix WeakPtrFactory member ordering in chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding more changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_galleries/fileapi/iphoto_file_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 15e834ce8398a5ab36a009371111f482b540b402..1641d8ae2c95fa89d9f3dab3f3b4cdd0b62f76fe 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -960,13 +960,13 @@ class Browser : public TabStripModelObserver,
// True if the browser window has been shown at least once.
bool window_has_shown_;
- // The following factory is used for chrome update coalescing.
- base::WeakPtrFactory<Browser> chrome_updater_factory_;
-
scoped_ptr<BrowserContentTranslateDriverObserver> translate_driver_observer_;
scoped_ptr<chrome::ValidationMessageBubble> validation_message_bubble_;
+ // The following factory is used for chrome update coalescing.
+ base::WeakPtrFactory<Browser> chrome_updater_factory_;
+
// The following factory is used to close the frame at a later time.
base::WeakPtrFactory<Browser> weak_factory_;
« no previous file with comments | « chrome/browser/media_galleries/fileapi/iphoto_file_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698