Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 795943002: Fix WeakPtrFactory member ordering in chrome (Closed)

Created:
6 years ago by anujsharma
Modified:
6 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in chrome Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/62e915a1c0db1f62e9e4687d3670d5423a9ef720 Cr-Commit-Position: refs/heads/master@{#307945}

Patch Set 1 #

Patch Set 2 : Adding new changes #

Patch Set 3 : Adding more changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/media_galleries/fileapi/iphoto_file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
anujsharma
PTAL
6 years ago (2014-12-11 09:48:35 UTC) #2
Lei Zhang
lgtm
6 years ago (2014-12-11 18:13:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795943002/40001
6 years ago (2014-12-11 18:14:19 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-11 19:23:27 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 19:24:19 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/62e915a1c0db1f62e9e4687d3670d5423a9ef720
Cr-Commit-Position: refs/heads/master@{#307945}

Powered by Google App Engine
This is Rietveld 408576698