Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.h

Issue 795933009: [AiS] for desktop, two lines and font sytles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed old function declaration; fixed reference to color macros Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_result_view.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.h b/chrome/browser/ui/views/omnibox/omnibox_result_view.h
index 099027c6c88594f248a8c95723570b1f8d1ff9f1..bedea7ac91226b3e829037bb6e581fc799cb456a 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.h
@@ -10,11 +10,13 @@
#include "base/gtest_prod_util.h"
#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h"
#include "components/omnibox/autocomplete_match.h"
+#include "components/omnibox/suggestion_answer.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/animation/animation_delegate.h"
#include "ui/gfx/animation/slide_animation.h"
#include "ui/gfx/font_list.h"
#include "ui/gfx/geometry/rect.h"
+#include "ui/native_theme/native_theme.h"
msw 2015/03/18 18:03:37 Why is this needed here?
dschuyler 2015/03/18 19:16:49 That would be another holdover from a prior patch
#include "ui/views/controls/image_view.h"
#include "ui/views/view.h"
@@ -47,6 +49,10 @@ class OmniboxResultView : public views::View,
NUM_KINDS
};
+ // The minimum distance between the top and bottom of the text and the
+ // top or bottom of the row.
+ static const int kMinimumTextVerticalPadding = 3;
+
OmniboxResultView(OmniboxPopupContentsView* model,
int model_index,
LocationBarView* location_bar_view,
@@ -117,9 +123,6 @@ class OmniboxResultView : public views::View,
void set_edge_item_padding(int value) { edge_item_padding_ = value; }
void set_item_padding(int value) { item_padding_ = value; }
- void set_minimum_text_vertical_padding(int value) {
- minimum_text_vertical_padding_ = value;
- }
private:
// views::View:
@@ -155,12 +158,17 @@ class OmniboxResultView : public views::View,
bool is_ui_rtl,
bool is_match_contents_rtl) const;
+ int GetAnswerLineHeight() const;
+ int GetContentLineHeight() const;
+
+ void AppendAnswerText(gfx::RenderText* render_text,
+ const SuggestionAnswer::TextField& text_field);
+
static int default_icon_size_;
// Default values cached here, may be overridden using the setters above.
int edge_item_padding_;
int item_padding_;
- int minimum_text_vertical_padding_;
// This row's model and model index.
OmniboxPopupContentsView* model_;

Powered by Google App Engine
This is Rietveld 408576698