[AiS] for desktop, two lines and font sytles

chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

Index: chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc
diff --git a/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc b/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc
index 3dec05e03c2df7ed5ca6e361999b24e5561e8570..176d40d36cd545898d35ee1b19348959585d7424 100644
--- a/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc
+++ b/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc
@@ -10,6 +10,7 @@
 #include "chrome/browser/ui/libgtk2ui/gtk2_ui.h"
 #include "chrome/browser/ui/libgtk2ui/gtk2_util.h"
 #include "chrome/browser/ui/libgtk2ui/skia_utils_gtk2.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
@@ -93,6 +94,11 @@ GdkColor SelectedURLColor(GdkColor foreground, GdkColor background) {
   return libgtk2ui::SkColorToGdkColor(color_utils::HSLToSkColor(output, 255));
 }
 
+GdkColor GetReadableColor(uint32_t color, const GdkColor& background) {
+  return libgtk2ui::SkColorToGdkColor(color_utils::GetReadableColor(
+      color, libgtk2ui::GdkColorToSkColor(background)));
+}
+
 }  // namespace
 
 
@@ -373,6 +379,30 @@ GdkColor NativeThemeGtk2::GetSystemGdkColor(ColorId color_id) const {
       return GdkAlphaBlend(win_style->text[GTK_STATE_SELECTED],
                            win_style->bg[GTK_STATE_SELECTED], 0x34);
     }
+    case kColorId_ResultsTablePositiveText: {

[msw, 2015/03/18 18:03:36]

Colors have different meanings in other cultures. Is there any precedent for
selecting locale-based colors? Do UI/UX folks support using hard-coded green and
red as the base for good and bad?

[dschuyler, 2015/03/18 19:16:48]

Excellent point.  So far the UI doc says red and green, but I agree it would be
worth bringing up the localization question specifically.  Should I add a TODO
or enter a bug or email someone in particular about it?

[msw, 2015/03/18 20:20:16]

Filing a bug would be a good way to loop in the right people and start a
discussion. You can CC the AiS PM, ainslie@, and maybe ping
chrome-ui-review@google.com.

[Justin Donnelly, 2015/03/18 20:42:57]

It's probably also worth checking in first with johanstr@ and suggest-answers@
to see what consideration the GWS folks gave this question.

+      return GetReadableColor(SK_ColorGREEN,

[msw, 2015/03/18 18:03:36]

Should the positive/negative base colors have their own themed ids?
(or perhaps at least a hard-coded const value in their files)

[dschuyler, 2015/03/18 19:16:48]

I'm trying to understand what you mean - like as a data driven resource file
entry for the colors?  That sounds good.  I could use some help/tips on how to
follow up on that.  Should this get a TODO or bug or similar?

[msw, 2015/03/18 20:20:16]

I meant either (1) Making kColorId_ResultsTable[Positive|Negative]Color or
similar, or (2) just defining const SkColor
kResultsTable[Positive|Negative]Color = SK_ColorGREEN/SK_ColorRED; in this file
and the other theme files for use in these calculations. I'd suggest (1) if that
meant we could have a centralized place of getting consistent/localized values
across the theme implementations, but otherwise (2) might be okay.

[Peter Kasting, 2015/03/18 22:19:33]

(1) would make sense if we need it (but we don't know yet).  (2) would only make
sense if we do it once in some central location that all different theme files
pull from.

But honestly, I don't love the fact that we have these global theme constants at
all, and I filed a separate bug against Dave already hoping to clean this up in
the form of moving all this back to omnibox-specific files.  Given that, I
wouldn't spend time now on trying to centralize these colors.

+                              GetEntryStyle()->base[GTK_STATE_NORMAL]);
+    }
+    case kColorId_ResultsTablePositiveHoveredText: {
+      return GetReadableColor(SK_ColorGREEN,
+                              GetEntryStyle()->base[GTK_STATE_PRELIGHT]);
+    }
+    case kColorId_ResultsTablePositiveSelectedText: {
+      return GetReadableColor(SK_ColorGREEN,
+                              GetEntryStyle()->base[GTK_STATE_SELECTED]);
+    }
+    case kColorId_ResultsTableNegativeText: {
+      return GetReadableColor(SK_ColorRED,
+                              GetEntryStyle()->base[GTK_STATE_NORMAL]);
+    }
+    case kColorId_ResultsTableNegativeHoveredText: {
+      return GetReadableColor(SK_ColorRED,
+                              GetEntryStyle()->base[GTK_STATE_PRELIGHT]);
+    }
+    case kColorId_ResultsTableNegativeSelectedText: {
+      return GetReadableColor(SK_ColorRED,
+                              GetEntryStyle()->base[GTK_STATE_SELECTED]);
+    }
     case kColorId_NumColors:
       NOTREACHED();
       break;