Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 795933009: [AiS] for desktop, two lines and font sytles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review updates Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
index fe061f65a9c0175152fd9e6d013d990b650f4663..8e1e9285befb709c9c155c412c6cf5db8ab01327 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/ui/omnibox/omnibox_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/browser/ui/views/omnibox/omnibox_result_view.h"
+#include "components/omnibox/omnibox_field_trial.h"
#include "ui/base/theme_provider.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/image/image.h"
@@ -388,18 +389,11 @@ int OmniboxPopupContentsView::CalculatePopupHeight() {
// amount of space between the text and the popup border as there is in the
// interior between each row of text.
//
- // Discovering the exact amount of leading and padding around the font is
- // a bit tricky and platform-specific, but this computation seems to work in
- // practice.
- OmniboxResultView* result_view = result_view_at(0);
- outside_vertical_padding_ =
- (result_view->GetPreferredSize().height() -
- result_view->GetTextHeight());
-
+ // The * 2 accounts for vertical padding used at the top and bottom.
return popup_height +
- views::NonClientFrameView::kClientEdgeThickness + // Top border.
- outside_vertical_padding_ * 2 + // Padding.
- bottom_shadow_->height() - kBorderInterior; // Bottom border.
+ views::NonClientFrameView::kClientEdgeThickness + // Top border.
+ OmniboxResultView::kMinimumTextVerticalPadding * 2 + // Padding.
+ bottom_shadow_->height() - kBorderInterior; // Bottom border.
}
OmniboxResultView* OmniboxPopupContentsView::CreateResultView(

Powered by Google App Engine
This is Rietveld 408576698