Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: ui/native_theme/native_theme_win.cc

Issue 795933009: [AiS] for desktop, two lines and font sytles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using RGB macros for GTK colors Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/native_theme/native_theme.h ('K') | « ui/native_theme/native_theme.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/native_theme/native_theme_win.cc
diff --git a/ui/native_theme/native_theme_win.cc b/ui/native_theme/native_theme_win.cc
index 4429d6ba71e138521b4c631906b49c0620562c31..697bff131a9696692efa8b2017935ea5605001a5 100644
--- a/ui/native_theme/native_theme_win.cc
+++ b/ui/native_theme/native_theme_win.cc
@@ -641,6 +641,20 @@ SkColor NativeThemeWin::GetSystemColor(ColorId color_id) const {
case kColorId_ResultsTableSelectedDivider:
return color_utils::AlphaBlend(system_colors_[COLOR_HIGHLIGHTTEXT],
system_colors_[COLOR_HIGHLIGHT], 0x34);
+ case kColorId_ResultsTablePositiveText:
+ case kColorId_ResultsTablePositiveHoveredText:
+ return color_utils::GetReadableColor(SkColorSetRGB(0, 255, 0),
Peter Kasting 2015/03/17 22:01:45 Nit: Use SK_ColorGREEN here (and RED below). Thes
dschuyler 2015/03/17 22:57:55 Done.
+ system_colors_[COLOR_WINDOW]);
Peter Kasting 2015/03/17 22:01:45 The "Hovered" text states should be computed atop
dschuyler 2015/03/17 22:57:55 Done.
+ case kColorId_ResultsTablePositiveSelectedText:
+ return color_utils::GetReadableColor(SkColorSetRGB(0, 255, 0),
+ system_colors_[COLOR_HIGHLIGHT]);
+ case kColorId_ResultsTableNegativeText:
+ case kColorId_ResultsTableNegativeHoveredText:
+ return color_utils::GetReadableColor(SkColorSetRGB(255, 0, 0),
+ system_colors_[COLOR_WINDOW]);
+ case kColorId_ResultsTableNegativeSelectedText:
+ return color_utils::GetReadableColor(SkColorSetRGB(255, 0, 0),
+ system_colors_[COLOR_HIGHLIGHT]);
}
NOTREACHED();
return kInvalidColorIdColor;
« ui/native_theme/native_theme.h ('K') | « ui/native_theme/native_theme.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698