[AiS] for desktop, two lines and font sytles

chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/libgtk2ui/native_theme_gtk2.h"
 
 #include <gtk/gtk.h>
 
 #include "chrome/browser/ui/libgtk2ui/chrome_gtk_menu_subclasses.h"
 #include "chrome/browser/ui/libgtk2ui/gtk2_ui.h"
@@ skipping 355 matching lines @@
     case kColorId_ResultsTableHoveredDivider: {
       GtkStyle* win_style = GetWindowStyle();
       return GdkAlphaBlend(win_style->text[GTK_STATE_PRELIGHT],
                            win_style->bg[GTK_STATE_PRELIGHT], 0x34);
     }
     case kColorId_ResultsTableSelectedDivider: {
       GtkStyle* win_style = GetWindowStyle();
       return GdkAlphaBlend(win_style->text[GTK_STATE_SELECTED],
                            win_style->bg[GTK_STATE_SELECTED], 0x34);
     }
+    case kColorId_ResultsTablePositiveText: {
+      GdkColor color = {0};
+      color.green = ~0;
+      return color;

[Peter Kasting, 2015/03/14 01:54:13]

You should use GetReadableColor() anytime you hardcode a source color, to ensure
it's readable over the background.  See how native_theme_win.cc does this.

[dschuyler, 2015/03/16 21:49:09]

Done.

+    }
+    case kColorId_ResultsTablePositiveHoveredText: {
+      GdkColor color = {0};
+      color.green = ~0;
+      GtkStyle* entry_style = GetEntryStyle();
+      return GdkAlphaBlend(color, entry_style->base[GTK_STATE_PRELIGHT], 0x80);
+    }
+    case kColorId_ResultsTablePositiveSelectedText: {
+      GdkColor color = {0};
+      color.green = ~0;
+      GtkStyle* entry_style = GetEntryStyle();
+      return GdkAlphaBlend(color, entry_style->base[GTK_STATE_SELECTED], 0x80);

[Peter Kasting, 2015/03/14 01:54:14]

I don't think this is what you want.  You're making the selected text much lower
contrast by blending it with the selected background.  We use that trick above
to dim text, not to adjust for being selected.

I think instead what you want to do is use GetReadableColor() again as suggested
above, but with the selected background color instead of the normal one.

[dschuyler, 2015/03/16 21:49:09]

Done.

+    }
+    case kColorId_ResultsTableNegativeText: {
+      GdkColor color = {0};
+      color.red = ~0;
+      return color;
+    }
+    case kColorId_ResultsTableNegativeHoveredText: {
+      GdkColor color = {0};
+      color.red = ~0;
+      GtkStyle* entry_style = GetEntryStyle();
+      return GdkAlphaBlend(color, entry_style->base[GTK_STATE_PRELIGHT], 0x80);
+    }
+    case kColorId_ResultsTableNegativeSelectedText: {
+      GdkColor color = {0};
+      color.red = ~0;
+      GtkStyle* entry_style = GetEntryStyle();
+      return GdkAlphaBlend(color, entry_style->base[GTK_STATE_SELECTED], 0x80);
+    }
     case kColorId_NumColors:
       NOTREACHED();
       break;
   }
 
   return SkColorToGdkColor(kInvalidColorIdColor);
 }
 
 GtkWidget* NativeThemeGtk2::GetRealizedWindow() const {
   if (!fake_window_) {
@@ skipping 100 matching lines @@
                                                0, 0,
                                                rect.width(), rect.height());
   SkBitmap arrow = GdkPixbufToImageSkia(pb);
   canvas->drawBitmap(arrow, rect.x(), rect.y());
 
   g_object_unref(pb);
   g_object_unref(pm);
 }
 
 }  // namespace libgtk2ui