[AiS] for desktop, two lines and font sytles

ui/native_theme/fallback_theme.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/native_theme/fallback_theme.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/native_theme/common_theme.h"
@@ skipping 71 matching lines @@
       color_utils::AlphaBlend(
           SK_ColorBLACK, kTextfieldSelectionBackgroundFocused, 0xBB);
   static const SkColor kResultsTableSelectedOrHoveredUrl =
       SkColorSetARGB(0xff, 0x00, 0x66, 0x22);
   static const SkColor kResultsTableNormalDivider = color_utils::AlphaBlend(
       kResultsTableNormalText, kTextfieldDefaultBackground, 0x34);
   static const SkColor kResultsTableHoveredDivider = color_utils::AlphaBlend(
       kResultsTableHoveredText, kResultsTableHoveredBackground, 0x34);
   static const SkColor kResultsTabSelectedDivider = color_utils::AlphaBlend(
       kResultsTableSelectedText, kTextfieldSelectionBackgroundFocused, 0x34);
+  // Answers
+  static const SkColor kAnswerNormalText =

[Justin Donnelly, 2015/03/13 21:08:33]

I don't think it makes sense to define this as synonymous with
kResultsNormalText.

[dschuyler, 2015/03/13 21:48:23]

The reason I went with a separate list is that there are separate entries for
table, result table, tree, tool tip, text field, label, menu, and so on.  I
would have expected many of those to use the same values.  It felt like the
style of the code previously was to be specific rather than general.  I'm happy
to change it, I just wanted to mention the thinking behind the choice.

+      color_utils::AlphaBlend(SK_ColorBLACK, kTextfieldDefaultBackground, 0xDD);

[Justin Donnelly, 2015/03/13 21:08:33]

How did you choose the alpha value?  0xDD is the most common value above but
it's not clear what calculus was used (I'm guessing just what looked good).

[dschuyler, 2015/03/13 21:48:23]

Yes, I used what was used previously.  I don't know what previous math was used.
 I'm also guessing that that it was a prior developer's taste.  So another way
to say this is that I didn't have a compelling/defensible reason to vary from
the prior ratio used. :)

+  static const SkColor kAnswerNormalTextHovered = color_utils::AlphaBlend(
+      SK_ColorBLACK, kResultsTableHoveredBackground, 0xDD);
+  static const SkColor kAnswerNormalTextSelected = color_utils::AlphaBlend(
+      SK_ColorBLACK, kTextfieldSelectionBackgroundFocused, 0xDD);
+  static const SkColor kAnswerInfoText =
+      color_utils::AlphaBlend(SK_ColorGRAY, kTextfieldDefaultBackground, 0xDD);
+  static const SkColor kAnswerInfoTextHovered = color_utils::AlphaBlend(
+      SK_ColorGRAY, kResultsTableHoveredBackground, 0xDD);
+  static const SkColor kAnswerInfoTextSelected = color_utils::AlphaBlend(
+      SK_ColorGRAY, kTextfieldSelectionBackgroundFocused, 0xDD);
+  static const SkColor kAnswerLinkText =
+      color_utils::AlphaBlend(SK_ColorBLUE, kTextfieldDefaultBackground, 0xDD);
+  static const SkColor kAnswerLinkTextHovered = color_utils::AlphaBlend(
+      SK_ColorBLUE, kResultsTableHoveredBackground, 0xDD);
+  static const SkColor kAnswerLinkTextSelected = color_utils::AlphaBlend(
+      SK_ColorBLUE, kTextfieldSelectionBackgroundFocused, 0xDD);
+  static const SkColor kAnswerPositiveText =
+      color_utils::AlphaBlend(SK_ColorGREEN, kTextfieldDefaultBackground, 0xDD);
+  static const SkColor kAnswerPositiveTextHovered = color_utils::AlphaBlend(
+      SK_ColorGREEN, kResultsTableHoveredBackground, 0xDD);
+  static const SkColor kAnswerPositiveTextSelected = color_utils::AlphaBlend(
+      SK_ColorGREEN, kTextfieldSelectionBackgroundFocused, 0xDD);
+  static const SkColor kAnswerNegativeText =
+      color_utils::AlphaBlend(SK_ColorRED, kTextfieldDefaultBackground, 0xDD);
+  static const SkColor kAnswerNegativeTextHovered = color_utils::AlphaBlend(
+      SK_ColorRED, kResultsTableHoveredBackground, 0xDD);
+  static const SkColor kAnswerNegativeTextSelected = color_utils::AlphaBlend(
+      SK_ColorRED, kTextfieldSelectionBackgroundFocused, 0xDD);
 
   SkColor color;
   if (CommonThemeGetSystemColor(color_id, &color))
     return color;
 
   switch (color_id) {
     // Windows
     case kColorId_WindowBackground:
       return kWindowBackgroundColor;
 
@@ skipping 97 matching lines @@
     case kColorId_ResultsTableHoveredUrl:
     case kColorId_ResultsTableSelectedUrl:
       return kResultsTableSelectedOrHoveredUrl;
     case kColorId_ResultsTableNormalDivider:
       return kResultsTableNormalDivider;
     case kColorId_ResultsTableHoveredDivider:
       return kResultsTableHoveredDivider;
     case kColorId_ResultsTableSelectedDivider:
       return kResultsTabSelectedDivider;
 
+    // Answers
+    case kColorId_AnswerNormalText:
+      return kAnswerNormalText;
+    case kColorId_AnswerNormalTextHovered:
+      return kAnswerNormalTextHovered;
+    case kColorId_AnswerNormalTextSelected:
+      return kAnswerNormalTextSelected;
+    case kColorId_AnswerInfoText:
+      return kAnswerInfoText;
+    case kColorId_AnswerInfoTextHovered:
+      return kAnswerInfoTextHovered;
+    case kColorId_AnswerInfoTextSelected:
+      return kAnswerInfoTextSelected;
+    case kColorId_AnswerLinkText:
+      return kAnswerLinkText;
+    case kColorId_AnswerLinkTextHovered:
+      return kAnswerLinkTextHovered;
+    case kColorId_AnswerLinkTextSelected:
+      return kAnswerLinkTextSelected;
+    case kColorId_AnswerPositiveText:
+      return kAnswerPositiveText;
+    case kColorId_AnswerPositiveTextHovered:
+      return kAnswerPositiveTextHovered;
+    case kColorId_AnswerPositiveTextSelected:
+      return kAnswerPositiveTextSelected;
+    case kColorId_AnswerNegativeText:
+      return kAnswerNegativeText;
+    case kColorId_AnswerNegativeTextHovered:
+      return kAnswerNegativeTextHovered;
+    case kColorId_AnswerNegativeTextSelected:
+      return kAnswerNegativeTextSelected;
+
     default:
       NOTREACHED();
       break;
   }
 
   return kInvalidColorIdColor;
 }
 
 }  // namespace ui