Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 795933008: Allow ability to handle cursor position changes on gpu IO thread (Closed)

Created:
5 years, 11 months ago by alexst (slow to review)
Modified:
5 years, 11 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU main could be very janky depending on what is being rendered, whenever possible, we need to handle cursor moves on GPU IO thread. BUG= Committed: https://crrev.com/2e8ed92e162ff1684b4f97fc7a9bbdaa2d78451b Cr-Commit-Position: refs/heads/master@{#310614}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : cleanup #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -6 lines) Patch
M ui/ozone/platform/dri/dri_gpu_platform_support.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_gpu_platform_support.cc View 1 2 3 4 5 4 chunks +109 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
alexst (slow to review)
Please have a look, guys.
5 years, 11 months ago (2015-01-08 02:01:32 UTC) #2
spang
lgtm https://codereview.chromium.org/795933008/diff/100001/ui/ozone/platform/dri/dri_gpu_platform_support.cc File ui/ozone/platform/dri/dri_gpu_platform_support.cc (right): https://codereview.chromium.org/795933008/diff/100001/ui/ozone/platform/dri/dri_gpu_platform_support.cc#newcode32 ui/ozone/platform/dri/dri_gpu_platform_support.cc:32: io_thread_task_runner_ = base::MessageLoop::current()->task_runner(); I think the preferred spelling ...
5 years, 11 months ago (2015-01-08 18:58:30 UTC) #3
spang
On 2015/01/08 18:58:30, spang wrote: > lgtm > > https://codereview.chromium.org/795933008/diff/100001/ui/ozone/platform/dri/dri_gpu_platform_support.cc > File ui/ozone/platform/dri/dri_gpu_platform_support.cc (right): > ...
5 years, 11 months ago (2015-01-08 18:58:57 UTC) #4
alexst (slow to review)
PTAL
5 years, 11 months ago (2015-01-08 19:46:43 UTC) #5
spang
lgtm
5 years, 11 months ago (2015-01-08 20:01:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795933008/120001
5 years, 11 months ago (2015-01-08 21:43:54 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 11 months ago (2015-01-08 22:30:00 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 22:30:50 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2e8ed92e162ff1684b4f97fc7a9bbdaa2d78451b
Cr-Commit-Position: refs/heads/master@{#310614}

Powered by Google App Engine
This is Rietveld 408576698