Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 795863002: [AppList] Use local favicons/icons with URLSuggestionResult (Closed)

Created:
6 years ago by Mathieu
Modified:
6 years ago
Reviewers:
benwells, Matt Giuca, huangs
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[AppList] Use local favicons/icons with URLSuggestionResult If available, will use local icons. Otherwise fallback to server provided image. BUG=440487 TBR=stevenjb Committed: https://crrev.com/1d9783347527cd7d1936c410adca28632524cf7f Cr-Commit-Position: refs/heads/master@{#307973}

Patch Set 1 #

Total comments: 8

Patch Set 2 : addressed comments #

Total comments: 11

Patch Set 3 : addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -9 lines) Patch
M chrome/browser/ui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.h View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc View 1 2 3 chunks +49 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Mathieu
Hi Matt, Can you have a look? Thanks.
6 years ago (2014-12-11 03:32:51 UTC) #2
Matt Giuca
+benwells for comment on use of favicons. lgtm because all of my comments are speculative. ...
6 years ago (2014-12-11 05:59:59 UTC) #3
Mathieu
Sam, You will be intereted in Matt's comments below RE:icons. You should probably review this ...
6 years ago (2014-12-11 14:27:55 UTC) #5
huangs
Suggest also to get michaelbai@ to take a look. https://codereview.chromium.org/795863002/diff/20001/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc File chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc (right): https://codereview.chromium.org/795863002/diff/20001/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc#newcode34 chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc:34: ...
6 years ago (2014-12-11 19:18:54 UTC) #6
Mathieu
Thanks, I think it's simple enough that we don't need extra reviewers. Another look? https://codereview.chromium.org/795863002/diff/20001/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc ...
6 years ago (2014-12-11 19:27:14 UTC) #7
huangs
lgtm
6 years ago (2014-12-11 19:35:25 UTC) #8
Mathieu
Thanks, TBR stevenjb because of DEPS presubmit asking for a review of DEPS owner.
6 years ago (2014-12-11 19:37:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795863002/40001
6 years ago (2014-12-11 19:37:36 UTC) #13
tfarina
https://codereview.chromium.org/795863002/diff/20001/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc File chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc (right): https://codereview.chromium.org/795863002/diff/20001/chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc#newcode34 chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc:34: weak_ptr_factory_(this), On 2014/12/11 19:18:54, huangs1 wrote: > Make |weak_ptr_factory_| ...
6 years ago (2014-12-11 20:42:39 UTC) #14
benwells
Yep, agree with Matt that 16x16 icons scaled up look terrible. There is code in ...
6 years ago (2014-12-11 20:51:18 UTC) #16
benwells
On 2014/12/11 20:51:18, benwells wrote: > Yep, agree with Matt that 16x16 icons scaled up ...
6 years ago (2014-12-11 20:52:11 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-11 21:04:07 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-11 21:05:58 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1d9783347527cd7d1936c410adca28632524cf7f
Cr-Commit-Position: refs/heads/master@{#307973}

Powered by Google App Engine
This is Rietveld 408576698