Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 795843002: Remove GetBitmapForSharedMemory from cc::SharedBitmapManager (Closed)

Created:
6 years ago by jbauman
Modified:
6 years ago
Reviewers:
danakj, piman
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GetBitmapForSharedMemory from cc::SharedBitmapManager This is only used in specific circumstances in the renderer, so move it to ChildSharedBitmapManager. Committed: https://crrev.com/27e8203c9de55da9f9451a270082de0ca2ca1d01 Cr-Commit-Position: refs/heads/master@{#308014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M cc/resources/shared_bitmap_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/test_shared_bitmap_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/test_shared_bitmap_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/child/child_shared_bitmap_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/host_shared_bitmap_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbauman
6 years ago (2014-12-11 02:24:08 UTC) #2
danakj
LGTM
6 years ago (2014-12-11 18:00:25 UTC) #4
piman
lgtm
6 years ago (2014-12-11 18:16:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795843002/1
6 years ago (2014-12-11 23:08:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 00:59:49 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 01:00:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e8203c9de55da9f9451a270082de0ca2ca1d01
Cr-Commit-Position: refs/heads/master@{#308014}

Powered by Google App Engine
This is Rietveld 408576698