Issue 795833006: Revert of [turbofan] Improve typed lowering of JSBitwiseAnd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 795833006: Revert of [turbofan] Improve typed lowering of JSBitwiseAnd. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer

Modified:
5 years, 11 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [turbofan] Improve typed lowering of JSBitwiseAnd. (patchset #1 id:1 of https://codereview.chromium.org/811653004/) Reason for revert: Breaks SQLite Original issue's description: > [turbofan] Improve typed lowering of JSBitwiseAnd. > > TEST=unittests > R=jarin@chromium.org > > Committed: https://crrev.com/284e1108182995abe85f580bc813d26491642b8c > Cr-Commit-Position: refs/heads/master@{#26046} TBR=jarin@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/214387fce189be03730c237e0576f4bc0f745a84 Cr-Commit-Position: refs/heads/master@{#26048}

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -112 lines)			Patch
M	src/compiler/js-typed-lowering.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View	7 chunks	+14 lines, -63 lines	0 comments	Download
M	test/unittests/compiler/js-typed-lowering-unittest.cc	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	test/unittests/compiler/node-test-utils.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/unittests/compiler/node-test-utils.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Created Revert of [turbofan] Improve typed lowering of JSBitwiseAnd.

5 years, 11 months ago (2015-01-14 09:06:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795833006/1

5 years, 11 months ago (2015-01-14 09:06:41 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 09:07:18 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/214387fce189be03730c237e0576f4bc0f745a84
Cr-Commit-Position: refs/heads/master@{#26048}