Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: Source/core/html/HTMLCanvasElement.h

Issue 795833004: Use dictionaries for context creation attributes. Eliminate custom bindings. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/ImageBitmapTest.cpp ('k') | Source/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLCanvasElement.h
diff --git a/Source/core/html/HTMLCanvasElement.h b/Source/core/html/HTMLCanvasElement.h
index 60a1a606b259de724848dd38c51d0fb124517c08..d5ab1443700d15a0bb93f4647837ec876b77bd84 100644
--- a/Source/core/html/HTMLCanvasElement.h
+++ b/Source/core/html/HTMLCanvasElement.h
@@ -28,6 +28,8 @@
#ifndef HTMLCanvasElement_h
#define HTMLCanvasElement_h
+#include "bindings/core/v8/ScriptValue.h"
+#include "bindings/core/v8/UnionTypesCore.h"
#include "core/dom/Document.h"
#include "core/html/HTMLElement.h"
#include "core/html/canvas/CanvasImageSource.h"
@@ -44,7 +46,7 @@
namespace blink {
class AffineTransform;
-class CanvasContextAttributes;
+class CanvasContextCreationAttributes;
class CanvasRenderingContext;
class GraphicsContext;
class GraphicsContextStateSaver;
@@ -100,7 +102,10 @@ public:
reset();
}
- CanvasRenderingContext* getContext(const String&, CanvasContextAttributes* attributes = 0);
+ // Called by HTMLCanvasElement's V8 bindings.
+ ScriptValue getContext(ScriptState*, const String&, const CanvasContextCreationAttributes&);
+ // Called by Document::getCSSCanvasContext as well as above getContext() variant.
+ void getContext(const String&, const CanvasContextCreationAttributes&, CanvasRenderingContext2DOrWebGLRenderingContext&);
bool isPaintable() const;
static String toEncodingMimeType(const String& mimeType);
« no previous file with comments | « Source/core/frame/ImageBitmapTest.cpp ('k') | Source/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698