Source/bindings/scripts/v8_dictionary.py - Issue 795833004: Use dictionaries for context creation attributes. Eliminate custom bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 795833004: Use dictionaries for context creation attributes. Eliminate custom bindings. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed layout test failures. Addressed review feedback. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_dictionary.py

diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py

index 72ad3a7fcb48612fdb1101a05c6a3cc6a7b9ce20..09ddb5802649ae556c6408350f8b7da25d690a88 100644

--- a/Source/bindings/scripts/v8_dictionary.py

+++ b/Source/bindings/scripts/v8_dictionary.py

@@ -59,6 +59,7 @@ def dictionary_context(dictionary, interfaces_info):

'members': [member_context(member)

for member in sorted(dictionary.members,

key=operator.attrgetter('name'))],

+ 'use_permissive_dictionary_conversion': 'PermissiveDictionaryConversion' in dictionary.extended_attributes,

'v8_class': v8_types.v8_type(cpp_class),

'v8_original_class': v8_types.v8_type(dictionary.name),

}

« no previous file with comments | « Source/bindings/core/v8/v8.gypi ('k') | Source/bindings/scripts/v8_methods.py » ('j') | Source/core/html/HTMLCanvasElement.idl » ('J')