Source/core/html/canvas/Canvas2DContextAttributes.idl - Issue 795833004: Use dictionaries for context creation attributes. Eliminate custom bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/Canvas2DContextAttributes.idl

Issue 795833004: Use dictionaries for context creation attributes. Eliminate custom bindings. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLCanvasElement.idl ('K') | « Source/core/html/canvas/Canvas2DContextAttributes.cpp ('k') | Source/core/html/canvas/CanvasContextAttributes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/Canvas2DContextAttributes.idl

diff --git a/Source/core/html/canvas/Canvas2DContextAttributes.idl b/Source/core/html/canvas/Canvas2DContextAttributes.idl

index f7dfab1fa373c4fbd805806a854dcd74b71a0644..4de5f9bd5e9a4fafd0bc9c2451c0f4ca2b791544 100644

--- a/Source/core/html/canvas/Canvas2DContextAttributes.idl

+++ b/Source/core/html/canvas/Canvas2DContextAttributes.idl

@@ -24,10 +24,9 @@

* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

- NoInterfaceObject,

- WillBeGarbageCollected,

-] interface Canvas2DContextAttributes {

- attribute boolean alpha;

- [RuntimeEnabled=ExperimentalCanvasFeatures] attribute DOMString storage;

+dictionary Canvas2DContextAttributes {

+ boolean alpha = true;

+ // Note: the bindings generator ignores the RuntimeEnabled

+ // extended attribute for dictionary members.

bashi 2014/12/12 00:35:24 Could you replace "Note" with "FIXME"? I filed a b

Ken Russell (switch to Gerrit) 2014/12/12 06:59:31 Actually, I've deleted this member based on junov'

+ [RuntimeEnabled=ExperimentalCanvasFeatures] DOMString storage;

};