A link inside a <label> element is not accessible

A link inside a <label> element is not accessible

BUG=404867
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187322

[ramya.v, 2014-12-11 07:03:19]

ramya.v@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[ramya.v, 2014-12-11 07:03:20]

PTAL!


Thanks.

[ramya.v, 2014-12-11 15:50:23]

On 2014/12/11 07:03:20, ramya.v wrote:
> PTAL!
> 
> 
> Thanks.

@dominic - could you please review

Thanks

[dmazzoni, 2014-12-11 21:46:23]

The code change is good, but please add a layout test. Use the same HTML as
the bug.

On Thu, Dec 11, 2014 at 7:50 AM, <ramya.v@samsung.com> wrote:

> On 2014/12/11 07:03:20, ramya.v wrote:
>
>> PTAL!
>>
>
>
>  Thanks.
>>
>
> @dominic - could you please review
>
> Thanks
>
> https://codereview.chromium.org/795833003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[ramya.v, 2014-12-12 06:11:19]

On 2014/12/11 21:46:23, dmazzoni_ooo_until_dec_16 wrote:
> The code change is good, but please add a layout test. Use the same HTML as
> the bug.
> 
> On Thu, Dec 11, 2014 at 7:50 AM, <mailto:ramya.v@samsung.com> wrote:
> 
> > On 2014/12/11 07:03:20, ramya.v wrote:
> >
> >> PTAL!
> >>
> >
> >
> >  Thanks.
> >>
> >
> > @dominic - could you please review
> >
> > Thanks
> >
> > https://codereview.chromium.org/795833003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.


@aboxhall
Added layout test case as suggested by dominic. Could you please review the
patch as he is on leave.

Thanks.

[aboxhall, 2014-12-12 18:05:25]

LGTM but please consider modifying the test to be more readable (see comment
inline).

https://codereview.chromium.org/795833003/diff/20001/LayoutTests/accessibilit...
File LayoutTests/accessibility/link-inside-label.html (right):

https://codereview.chromium.org/795833003/diff/20001/LayoutTests/accessibilit...
LayoutTests/accessibility/link-inside-label.html:26: result.innerText = "\nRole
should be:" + test.role;
This is a little confusing - I would rephrase as "Role was: " + test.role - or
include ../resources/js-test.js and use the shouldBe function (see
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
for example).

[ramya.v, 2014-12-15 04:46:12]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2014-12-15 04:46:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795833003/40001

[commit-bot: I haz the power, 2014-12-15 04:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-15 04:50:07]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[ramya.v, 2014-12-15 05:58:11]

On 2014/12/15 04:50:07, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   blink_presubmit on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

@aboxhall Thank you so much for review comments.
@dominic
Need owners lgtm. PTAL.

Thanks!

[dmazzoni, 2014-12-17 00:55:14]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-12-17 00:55:14]

lgtm

[commit-bot: I haz the power, 2014-12-17 00:55:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795833003/40001

[commit-bot: I haz the power, 2014-12-17 02:13:23]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187322