Issue 795823005: Revert of Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 795823005: Revert of Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning. (Closed)

Created:
6 years ago by mtklein

Modified:
6 years ago

Reviewers:
caryclark, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning. (patchset #1 id:1 of https://codereview.chromium.org/807553002/) Reason for revert: uses __builtins not available on all our compilers Original issue's description: > Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning. > > This warning should now go away: > > ../../third_party/externals/libwebp/src/enc/quant.c:105:23: warning: unused variable 'kCoeffThresh' [-Wunused-const-variable] > static const uint16_t kCoeffThresh[16] = { > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e655557a551c545f4153b0764269298cd01cd0c0 TBR=caryclark@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/449998d3f02aaaf4f62680aade1720527f938570

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	gyp/libwebp.gyp	View		5 chunks	+2 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning.

6 years ago (2014-12-15 20:22:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795823005/1

6 years ago (2014-12-15 20:22:52 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-15 20:23:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/449998d3f02aaaf4f62680aade1720527f938570