Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 795823003: API migration: picture.draw -> picture.playback (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
danakj, reveman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

API migration: picture.draw -> picture.playback patch from issue 802973002 at patchset 1 (http://crrev.com/802973002#ps1) BUG= TBR=benm@chromium.org add tbr for android_webview owner Committed: https://crrev.com/74eefda9ee8958108a74f8cee4d37a0e533cf129 Cr-Commit-Position: refs/heads/master@{#308383}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix android call-site #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M android_webview/native/aw_picture.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/drawing_display_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
reed1
6 years ago (2014-12-15 14:39:42 UTC) #2
danakj
On 2014/12/15 14:39:42, reed1 wrote: Lgtm
6 years ago (2014-12-15 15:57:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795823003/20001
6 years ago (2014-12-15 16:03:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/42037) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/31003) android_dbg_tests_recipe ...
6 years ago (2014-12-15 16:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795823003/40001
6 years ago (2014-12-15 17:00:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30499)
6 years ago (2014-12-15 17:05:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795823003/40001
6 years ago (2014-12-15 18:57:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-15 19:01:16 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-15 19:01:57 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/74eefda9ee8958108a74f8cee4d37a0e533cf129
Cr-Commit-Position: refs/heads/master@{#308383}

Powered by Google App Engine
This is Rietveld 408576698