chrome/browser/chrome_content_browser_client.cc - Issue 795773002: Un-refcount SSLClientAuthHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 795773002: Un-refcount SSLClientAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 461c50db639f4291e7d28446d7d26912f0e22c2c..1560884c240adabdf1677596b3a7cbf50dd33925 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -1775,7 +1775,8 @@ void ChromeContentBrowserClient::SelectClientCertificate(

render_process_id, render_frame_id);

WebContents* tab = WebContents::FromRenderFrameHost(rfh);

if (!tab) {

- NOTREACHED();

+ // TODO(davidben): This makes the request hang, but returning no certificate

+ // also breaks. It should abort the request. See https://crbug.com/417092

return;

}