Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 795773002: Un-refcount SSLClientAuthHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index d0d67bddd75bc48fabf404937a49900eb3c281df..11f32d8ed768e51f5a43af3ea5ce8d4de2f8908c 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -97,8 +97,7 @@ ResourceLoader::ResourceLoader(scoped_ptr<net::URLRequest> request,
ResourceLoader::~ResourceLoader() {
if (login_delegate_.get())
login_delegate_->OnRequestCancelled();
- if (ssl_client_auth_handler_.get())
- ssl_client_auth_handler_->OnRequestCancelled();
+ ssl_client_auth_handler_.reset();
// Run ResourceHandler destructor before we tear-down the rest of our state
// as the ResourceHandler may want to inspect the URLRequest and other state.
@@ -288,14 +287,12 @@ void ResourceLoader::OnCertificateRequested(
return;
}
- DCHECK(!ssl_client_auth_handler_.get())
+ DCHECK(!ssl_client_auth_handler_)
<< "OnCertificateRequested called with ssl_client_auth_handler pending";
- ssl_client_auth_handler_ = new SSLClientAuthHandler(
- GetRequestInfo()->GetContext()->CreateClientCertStore(),
- request_.get(),
- cert_info,
- base::Bind(&ResourceLoader::ContinueWithCertificate,
- weak_ptr_factory_.GetWeakPtr()));
+ ssl_client_auth_handler_.reset(new SSLClientAuthHandler(
+ GetRequestInfo()->GetContext()->CreateClientCertStore(), request_.get(),
+ cert_info, base::Bind(&ResourceLoader::ContinueWithCertificate,
+ weak_ptr_factory_.GetWeakPtr())));
ssl_client_auth_handler_->SelectCertificate();
}
@@ -568,10 +565,7 @@ void ResourceLoader::CancelRequestInternal(int error, bool from_renderer) {
login_delegate_->OnRequestCancelled();
login_delegate_ = NULL;
}
- if (ssl_client_auth_handler_.get()) {
- ssl_client_auth_handler_->OnRequestCancelled();
- ssl_client_auth_handler_ = NULL;
- }
+ ssl_client_auth_handler_.reset();
request_->CancelWithError(error);
@@ -838,7 +832,7 @@ void ResourceLoader::RecordHistograms() {
}
void ResourceLoader::ContinueWithCertificate(net::X509Certificate* cert) {
- ssl_client_auth_handler_ = NULL;
+ ssl_client_auth_handler_.reset();
request_->ContinueWithCertificate(cert);
}

Powered by Google App Engine
This is Rietveld 408576698