content/browser/renderer_host/media/media_stream_ui_proxy.h - Issue 795703003: Don't auto allow access to media devices unless a the security origin of the requester is the same …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_ui_proxy.h

Issue 795703003: Don't auto allow access to media devices unless a the security origin of the requester is the same … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nit. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/media_stream_manager.cc ('k') | content/browser/renderer_host/media/media_stream_ui_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_ui_proxy.h

diff --git a/content/browser/renderer_host/media/media_stream_ui_proxy.h b/content/browser/renderer_host/media/media_stream_ui_proxy.h

index 23fc592e62b234836593036b5178af0c1130b3cb..117f7c4a6661d7b774229d9951ea3379a5b4ba46 100644

--- a/content/browser/renderer_host/media/media_stream_ui_proxy.h

+++ b/content/browser/renderer_host/media/media_stream_ui_proxy.h

@@ -38,7 +38,7 @@ class CONTENT_EXPORT MediaStreamUIProxy {

// WebContentsDelegate::RequestMediaAccessPermission(). The specified

// |response_callback| is called when the WebContentsDelegate approves or

// denies request.

- virtual void RequestAccess(const MediaStreamRequest& request,

+ virtual void RequestAccess(scoped_ptr<MediaStreamRequest> request,

const ResponseCallback& response_callback);

// Checks if we have permission to access the microphone or camera. Note that

@@ -97,7 +97,7 @@ class CONTENT_EXPORT FakeMediaStreamUIProxy : public MediaStreamUIProxy {

void SetCameraAccess(bool access);

// MediaStreamUIProxy overrides.

- void RequestAccess(const MediaStreamRequest& request,

+ void RequestAccess(scoped_ptr<MediaStreamRequest> request,

const ResponseCallback& response_callback) override;

void CheckAccess(const GURL& security_origin,

MediaStreamType type,