chrome/browser/media/media_stream_devices_controller.cc - Issue 795703003: Don't auto allow access to media devices unless a the security origin of the requester is the same …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/media_stream_devices_controller.cc

Issue 795703003: Don't auto allow access to media devices unless a the security origin of the requester is the same … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix problem with that the ui_request_ was used for state updates. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/media/media_stream_devices_controller.cc

diff --git a/chrome/browser/media/media_stream_devices_controller.cc b/chrome/browser/media/media_stream_devices_controller.cc

index 98a08f3f248a010514f6b774fc90f594e64a5365..dc0d0e8bbe436cf42364330c36b6636e2e8513b0 100644

--- a/chrome/browser/media/media_stream_devices_controller.cc

+++ b/chrome/browser/media/media_stream_devices_controller.cc

@@ -498,6 +498,11 @@ void MediaStreamDevicesController::RequestFinished() {

}

bool MediaStreamDevicesController::IsRequestAllowedByDefault() const {

+ // If not all ancestors of the requesting frame have the same origin, do not

+ // allow the request per default.

+ if (!request_.all_ancestors_have_same_origin)

tommi (sloooow) - chröme 2015/01/27 21:07:13 nit: Would it make sense to have a UMA stat for th

+ return false;

// The request from internal objects like chrome://URLs is always allowed.

if (CheckAllowAllMediaStreamContentForOrigin(profile_,

request_.security_origin)) {

« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree_node.h » ('j') | content/browser/renderer_host/media/media_stream_manager.cc » ('J')