chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h - Issue 795663003: [Mac Extensions Toolbar] Make the container's animationEndFrame always valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h

Issue 795663003: [Mac Extensions Toolbar] Make the container's animationEndFrame always valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm » ('j') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h

index 05caee1b610a1fe906df18f85e2de0270a68a427..c556abf641d30febad69c35f8115c05ba81f7767 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h

@@ -32,10 +32,6 @@ extern NSString* const kTranslationWithDelta;

// The frame encompasing the grippy used for resizing the container.

NSRect grippyRect_;

- // The end frame of the animation currently running for this container or

- // NSZeroRect if none is in progress.

- NSRect animationEndFrame_;

// Used to cache the original position within the container that initiated the

// drag.

NSPoint initialDragPoint_;

@@ -79,7 +75,10 @@ extern NSString* const kTranslationWithDelta;

// placement of surrounding elements.

- (CGFloat)resizeDeltaX;

-@property(nonatomic, readonly) NSRect animationEndFrame;

+// Returns the frame of the container after the running animation has finished.

+// If no animation is running, returns the container's current frame.

+- (NSRect)animationEndFrame;

@property(nonatomic) BOOL canDragLeft;

@property(nonatomic) BOOL canDragRight;

@property(nonatomic) BOOL grippyPinned;