Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: mojo/edk/js/tests/sample_service_tests.js

Issue 795593004: Update mojo sdk to rev cc531b32182099a5a034a99daff35ed5d38a61c8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More workarounds for MSVC Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/js/core.cc ('k') | mojo/edk/system/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/js/tests/sample_service_tests.js
diff --git a/mojo/edk/js/tests/sample_service_tests.js b/mojo/edk/js/tests/sample_service_tests.js
index 1b62e975185038ba4df621600d0ee8da874db16e..2afdf3e709fa50cd4c18c9add31d9ec44f73dbf5 100644
--- a/mojo/edk/js/tests/sample_service_tests.js
+++ b/mojo/edk/js/tests/sample_service_tests.js
@@ -9,7 +9,8 @@ define([
"mojo/public/interfaces/bindings/tests/sample_service.mojom",
"mojo/public/interfaces/bindings/tests/sample_import.mojom",
"mojo/public/interfaces/bindings/tests/sample_import2.mojom",
- ], function(console, hexdump, expect, sample, imported, imported2) {
+ "mojo/public/js/core",
+ ], function(console, hexdump, expect, sample, imported, imported2, core) {
var global = this;
@@ -138,7 +139,7 @@ define([
ServiceImpl.prototype.frobinate = function(foo, baz, port) {
checkFoo(foo);
expect(baz).toBe(sample.Service.BazOptions.EXTRA);
- expect(port).toBe(10);
+ expect(core.isHandle(port)).toBeTruthy();
global.result = "PASS";
};
@@ -163,6 +164,8 @@ define([
var foo = makeFoo();
checkFoo(foo);
- var port = 10;
- serviceProxy.frobinate(foo, sample.Service.BazOptions.EXTRA, port);
+ var pipe = core.createMessagePipe();
+ serviceProxy.frobinate(foo, sample.Service.BazOptions.EXTRA, pipe.handle0);
+ expect(core.close(pipe.handle0)).toBe(core.RESULT_OK);
+ expect(core.close(pipe.handle1)).toBe(core.RESULT_OK);
});
« no previous file with comments | « mojo/edk/js/core.cc ('k') | mojo/edk/system/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698