src/compiler/ast-graph-builder.cc - Issue 795573005: ES6 computed property names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 795573005: ES6 computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: moar cleanup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index 4ecbda764bf6402a628459988e4325cf3d61e0c2..8f110c6e5876accea718e4189073e93376d8b25e 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -916,7 +916,7 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {

ObjectLiteral::Property* property = expr->properties()->at(i);

if (property->IsCompileTimeValue()) continue;

- Literal* key = property->key();

+ Literal* key = property->key()->AsLiteral();

switch (property->kind()) {

case ObjectLiteral::Property::CONSTANT:

UNREACHABLE();