src/arm64/full-codegen-arm64.cc - Issue 795573005: ES6 computed property names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/full-codegen-arm64.cc

Issue 795573005: ES6 computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: moar cleanup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/full-codegen-arm64.cc

diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc

index 0d3d34b6950e111392d2dc7276195f5f84518acb..d50dcc225b09e743bf7a4554809a6f93ca1268c5 100644

--- a/src/arm64/full-codegen-arm64.cc

+++ b/src/arm64/full-codegen-arm64.cc

@@ -2185,7 +2185,7 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

__ Peek(scratch, 0); // prototype

}

__ Push(scratch);

- VisitForStackValue(key);

+ EmitPropertyKey(property);

VisitForStackValue(value);

EmitSetHomeObjectIfNeeded(value, 2);

@@ -2198,11 +2198,11 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

break;

case ObjectLiteral::Property::GETTER:

- __ CallRuntime(Runtime::kDefineClassGetter, 3);

+ __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3);

break;

case ObjectLiteral::Property::SETTER:

- __ CallRuntime(Runtime::kDefineClassSetter, 3);

+ __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3);

break;

default: