src/typing.cc - Issue 795573005: ES6 computed property names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 795573005: ES6 computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Moar tests Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index 3f63237596ae116a6882fab950dbc6a214a73cbc..425b82f1e21e7a1fcaa631514c48de6700dd04b5 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -407,7 +407,9 @@ void AstTyper::VisitObjectLiteral(ObjectLiteral* expr) {

if ((prop->kind() == ObjectLiteral::Property::MATERIALIZED_LITERAL &&

!CompileTimeValue::IsCompileTimeValue(prop->value())) ||

prop->kind() == ObjectLiteral::Property::COMPUTED) {

- if (prop->key()->value()->IsInternalizedString() && prop->emit_store()) {

+ if (!prop->is_computed_name() &&

+ prop->key()->AsLiteral()->value()->IsInternalizedString() &&

+ prop->emit_store()) {

prop->RecordTypeFeedback(oracle());

}