Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 795573005: ES6 computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 4ecbda764bf6402a628459988e4325cf3d61e0c2..8f110c6e5876accea718e4189073e93376d8b25e 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -916,7 +916,7 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {
ObjectLiteral::Property* property = expr->properties()->at(i);
if (property->IsCompileTimeValue()) continue;
- Literal* key = property->key();
+ Literal* key = property->key()->AsLiteral();
arv (Not doing code reviews) 2014/12/10 23:38:13 This is not going to work. I disabled the tests fo
Dmitry Lomov (no reviews) 2014/12/11 12:34:35 Probably should be a DontOptimize reason for Turbo
arv (Not doing code reviews) 2014/12/11 23:10:33 Do you mean mark all ObjectLiteral as not optimiza
switch (property->kind()) {
case ObjectLiteral::Property::CONSTANT:
UNREACHABLE();

Powered by Google App Engine
This is Rietveld 408576698