extensions/common/permissions/api_permission.cc - Issue 795543002: Added PermissionIDSet to APIPermissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/api_permission.cc

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix

Patch Set: Removed unnecessary constructor and added tests for API permissions Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/permissions/api_permission.h ('K') | « extensions/common/permissions/api_permission.h ('k') | extensions/common/permissions/api_permission_set.h » ('j') | extensions/common/permissions/api_permission_set.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/api_permission.cc

diff --git a/extensions/common/permissions/api_permission.cc b/extensions/common/permissions/api_permission.cc

index d5fd5a1f3d7d5068505c7d0e90c1985977b4f2da..862419f773271bb612043df1b8889ea3ef055369 100644

--- a/extensions/common/permissions/api_permission.cc

+++ b/extensions/common/permissions/api_permission.cc

@@ -4,6 +4,7 @@

#include "extensions/common/permissions/api_permission.h"

+#include "extensions/common/permissions/api_permission_set.h"

#include "ui/base/l10n/l10n_util.h"

namespace {

@@ -20,6 +21,10 @@ class SimpleAPIPermission : public APIPermission {

~SimpleAPIPermission() override {}

+ extensions::PermissionIDSet GetPermissions() const override {

+ return extensions::PermissionIDSet(id());

+ }

bool HasMessages() const override {

return info()->message_id() > PermissionMessage::kNone;

}