extensions/common/permissions/socket_permission.h - Issue 795543002: Added PermissionIDSet to APIPermissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/socket_permission.h

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix

Patch Set: Rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/settings_override_permission.cc ('k') | extensions/common/permissions/socket_permission.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/socket_permission.h

diff --git a/extensions/common/permissions/socket_permission.h b/extensions/common/permissions/socket_permission.h

index eb50d9ac85480e6d66b721c52dde7671415d095c..c2c11564f1f8797bb0ccfcd3d5f3091a68b9076e 100644

--- a/extensions/common/permissions/socket_permission.h

+++ b/extensions/common/permissions/socket_permission.h

@@ -28,14 +28,26 @@ class SocketPermission

~SocketPermission() override;

+ PermissionIDSet GetPermissions() const override;

// Returns the localized permission messages of this permission.

PermissionMessages GetMessages() const override;

private:

- bool AddAnyHostMessage(PermissionMessages& messages) const;

- void AddSubdomainHostMessage(PermissionMessages& messages) const;

- void AddSpecificHostMessage(PermissionMessages& messages) const;

- void AddNetworkListMessage(PermissionMessages& messages) const;

+ // Add all host messages for this manifest permission into the given lists.

+ // TODO(sashab): Remove the |messages| argument from these methods, and remove

+ // the AddAllHostMessages() function (move all the logic into GetPermissions()

+ // above).

+ void AddAllHostMessages(PermissionMessages& messages,