Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: extensions/common/permissions/settings_override_permission.h

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix
Patch Set: Removed unnecessary constructor and added tests for API permissions Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_ 5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_
6 #define EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_ 6 #define EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/common/permissions/api_permission.h" 10 #include "extensions/common/permissions/api_permission.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 // Takes care of creating custom permission messages for extensions that 14 // Takes care of creating custom permission messages for extensions that
15 // override settings. 15 // override settings.
16 class SettingsOverrideAPIPermission : public APIPermission { 16 class SettingsOverrideAPIPermission : public APIPermission {
17 public: 17 public:
18 SettingsOverrideAPIPermission(const APIPermissionInfo* permission, 18 SettingsOverrideAPIPermission(const APIPermissionInfo* permission,
19 const std::string& setting_value); 19 const std::string& setting_value);
20 ~SettingsOverrideAPIPermission() override; 20 ~SettingsOverrideAPIPermission() override;
21 21
22 // APIPermission overrides. 22 // APIPermission overrides.
23 PermissionIDSet GetPermissions() const override;
23 bool HasMessages() const override; 24 bool HasMessages() const override;
24 PermissionMessages GetMessages() const override; 25 PermissionMessages GetMessages() const override;
25 bool Check(const APIPermission::CheckParam* param) const override; 26 bool Check(const APIPermission::CheckParam* param) const override;
26 bool Contains(const APIPermission* rhs) const override; 27 bool Contains(const APIPermission* rhs) const override;
27 bool Equal(const APIPermission* rhs) const override; 28 bool Equal(const APIPermission* rhs) const override;
28 bool FromValue(const base::Value* value, 29 bool FromValue(const base::Value* value,
29 std::string* error, 30 std::string* error,
30 std::vector<std::string>* unhandled_permissions) override; 31 std::vector<std::string>* unhandled_permissions) override;
31 scoped_ptr<base::Value> ToValue() const override; 32 scoped_ptr<base::Value> ToValue() const override;
32 APIPermission* Clone() const override; 33 APIPermission* Clone() const override;
33 APIPermission* Diff(const APIPermission* rhs) const override; 34 APIPermission* Diff(const APIPermission* rhs) const override;
34 APIPermission* Union(const APIPermission* rhs) const override; 35 APIPermission* Union(const APIPermission* rhs) const override;
35 APIPermission* Intersect(const APIPermission* rhs) const override; 36 APIPermission* Intersect(const APIPermission* rhs) const override;
36 void Write(IPC::Message* m) const override; 37 void Write(IPC::Message* m) const override;
37 bool Read(const IPC::Message* m, PickleIterator* iter) override; 38 bool Read(const IPC::Message* m, PickleIterator* iter) override;
38 void Log(std::string* log) const override; 39 void Log(std::string* log) const override;
39 40
40 private: 41 private:
41 std::string setting_value_; 42 std::string setting_value_;
42 }; 43 };
43 44
44 } // namespace extensions 45 } // namespace extensions
45 46
46 #endif // EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_ 47 #endif // EXTENSIONS_COMMON_PERMISSIONS_SETTINGS_OVERRIDE_PERMISSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698