Added PermissionIDSet to APIPermissions

extensions/common/permissions/coalesced_permission_message.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_PERMISSIONS_COALESCED_PERMISSION_MESSAGE_H_
 #define EXTENSIONS_COMMON_PERMISSIONS_COALESCED_PERMISSION_MESSAGE_H_
 
-#include <set>
+#include <list>
 #include <string>
 
-#include "base/memory/scoped_vector.h"
-#include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/api_permission_set.h"
 
 namespace extensions {
 
 // The new kind of Chrome app/extension permission messages.
 //
 // A CoalescedPermissionMessage is an immutable object that represents a single
 // bullet in the list of an app or extension's permissions. It contains the
 // localized permission message to display, as well as the set of permissions
 // that contributed to that message (and should be revoked if this permission is
@@ skipping 12 matching lines @@
 // collapsed if needed. For example, host permission messages may list all the
 // sites the app has access to in |submessages|, with a summary message in
 // |message|.
 //
 // TODO(sashab): Add a custom revoke action for each permission and nested
 // permission message, registerable as a callback.
 // TODO(sashab): Once the existing PermissionMessage is no longer used, rename
 // this to PermissionMessage.
 class CoalescedPermissionMessage {
  public:
+  CoalescedPermissionMessage();

[sashab, 2014/12/10 08:57:49]

Not sure if we should include this... Technically, there should be no such thing
as an empty permission message. Will remove in a follow-up patch.

   CoalescedPermissionMessage(const base::string16& message,
                              const PermissionIDSet& permissions);
   CoalescedPermissionMessage(const base::string16& message,
                              const PermissionIDSet& permissions,
                              const std::vector<base::string16>& submessages);
   virtual ~CoalescedPermissionMessage();
 
   const base::string16& message() const { return message_; }
   const PermissionIDSet& permissions() const { return permissions_; }
   const std::vector<base::string16>& submessages() const {
     return submessages_;
   }
 
  private:
   const base::string16 message_;
   const PermissionIDSet permissions_;
   const std::vector<base::string16> submessages_;
-
-  DISALLOW_COPY_AND_ASSIGN(CoalescedPermissionMessage);
 };
 
-typedef std::vector<CoalescedPermissionMessage> CoalescedPermissionMessages;
+// Use a linked list to store our list of messages, since we will commonly be
+// iterating/removing elements but should never be accessing by index.
+typedef std::list<CoalescedPermissionMessage> CoalescedPermissionMessages;
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_PERMISSIONS_COALESCED_PERMISSION_MESSAGE_H_