Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 795513004: HelpApp: manifest.json release for M41 (Closed)

Created:
5 years, 11 months ago by cylee1
Modified:
5 years, 11 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HelpApp: manifest.json release for M41 BUG=447148 Committed: https://crrev.com/4e9a13299c4cc09f2f5a24501371432eef08adf4 Cr-Commit-Position: refs/heads/master@{#312606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/resources/help_app/manifest.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cylee1
Hi Dmitry, We moved the resource out of HelpApp to Genius. So the web_accessible_resource field ...
5 years, 11 months ago (2015-01-22 12:50:27 UTC) #2
Dmitry Polukhin
lgtm
5 years, 11 months ago (2015-01-22 12:51:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795513004/1
5 years, 11 months ago (2015-01-22 12:54:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 13:49:55 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 13:50:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e9a13299c4cc09f2f5a24501371432eef08adf4
Cr-Commit-Position: refs/heads/master@{#312606}

Powered by Google App Engine
This is Rietveld 408576698