Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 795493003: Don't create multiple WebRange objects for getting selection text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index cfad1196e1904c640ff28fc875d8889788d4aee4..a098a695de76e036c4a2dbaee5165a1475ebc2d4 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4057,8 +4057,7 @@ void RenderFrameImpl::SyncSelectionIfRequired() {
length = location + length - offset + kExtraCharsBeforeAndAfterSelection;
WebRange webrange = WebRange::fromDocumentRange(frame_, offset, length);
if (!webrange.isNull())
- text = WebRange::fromDocumentRange(
- frame_, offset, length).toPlainText();
+ text = webrange.toPlainText();
} else {
offset = location;
text = frame_->selectionAsText();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698