In Bookmark manager 'Add page' and 'Add Folder' always add new page or folder at the end.

chrome/browser/resources/bookmark_manager/js/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 /** @const */ var BookmarkList = bmm.BookmarkList;
 /** @const */ var BookmarkTree = bmm.BookmarkTree;
 /** @const */ var Command = cr.ui.Command;
 /** @const */ var LinkKind = cr.LinkKind;
 /** @const */ var ListItem = cr.ui.ListItem;
@@ skipping 1011 matching lines @@
 
 /**
  * Callback for the new folder command. This creates a new folder and starts
  * a rename of it.
  * @param {EventTarget=} opt_target The target to create a new folder in.
  */
 function newFolder(opt_target) {
   performGlobalUndo = null;  // This can't be undone, so disable global undo.
 
   var parentId = computeParentFolderForNewItem();
-
+  var newIndex = '';

[Bernhard Bauer, 2014/12/22 11:58:20]

|newIndex| is supposed to be an integer. Just because the Javascript type system
allows you to assign a value of a different type to it doesn't mean that is a
good idea. If you just leave this as undefined (i.e. `var newIndex;`), you can
pass it to chrome.bookmarks.create in the same call, so you don't need the
additional call below.

[Deepak, 2014/12/23 04:27:48]

Done.

+  var selectedItem = bmm.list.selectedItem;
   // Callback is called after tree and list data model updated.
   function createFolder(callback) {
+  if (selectedItem && document.activeElement != bmm.tree) {

[Bernhard Bauer, 2014/12/22 11:58:20]

The indentation is way off in this CL. I would suggest you familiarize yourself
with the Chromium style guide
(http://dev.chromium.org/developers/coding-style/), specifically the web
development style
(http://dev.chromium.org/developers/web-development-style-guide).

[Deepak, 2014/12/23 04:27:47]

Can you please tell me in specific about this.

[Bernhard Bauer, 2014/12/23 11:54:36]

The issues are fixed now.

+      if (!bmm.isFolder(selectedItem))
+        newIndex = 1 + bmm.list.dataModel.indexOf(selectedItem);

[Bernhard Bauer, 2014/12/22 11:58:20]

It's more idiomatic to put the constant summand as the second argument (`... +
1`).

[Deepak, 2014/12/23 04:27:47]

Done.

+    }
+    if (newIndex != '') {
+    chrome.bookmarks.create({
+      title: loadTimeData.getString('new_folder_name'),
+      parentId: parentId,
+      index: newIndex
+    }, callback);
+   } else {
+    // As create bookmark folder does not create bookmark node for empty index.

[Bernhard Bauer, 2014/12/22 11:58:21]

I have no idea what this comment is supposed to mean.

[Deepak, 2014/12/23 04:27:48]

This part of code is not required after taking newIndex as undefined.

     chrome.bookmarks.create({
       title: loadTimeData.getString('new_folder_name'),
       parentId: parentId
-    }, callback);
+      }, callback);
+    }
   }
 
   if ((opt_target || document.activeElement) == bmm.tree) {
     createFolder(function(newNode) {
       navigateTo(newNode.id, function() {
         bmm.treeLookup[newNode.id].editing = true;
       });
     });
     return;
   }
 
   function editNewFolderInList() {
     createFolder(function() {
-      var index = bmm.list.dataModel.length - 1;
+      var length = bmm.list.dataModel.length - 1;
+      if (newIndex != '' && newIndex <= length)

[Bernhard Bauer, 2014/12/22 11:58:20]

This callback will be called asynchronously. What if another item has been added
in the mean time, so |newIndex| is not the index of the newly created folder
anymore?

[Deepak, 2014/12/23 04:27:47]

I understand.
Can you please tell me some way to reproduce this.

[Bernhard Bauer, 2014/12/23 11:54:36]

I don't know how to reproduce this, but the onus is on you to prove that it
can't happen or that you're dealing with it adequately.

It seems that the newly created node is passed to the callback; could you use
that to look up the index in the model?

+        length = newIndex;

[Bernhard Bauer, 2014/12/22 11:58:20]

Why do you rename this variable to |length|, but then assign a value to it that
is not a length, but an index? Arguably, |index| was a better description.

[Deepak, 2014/12/23 04:27:48]

Done.

       var sm = bmm.list.selectionModel;
-      sm.anchorIndex = sm.leadIndex = sm.selectedIndex = index;
-      scrollIntoViewAndMakeEditable(index);
+      sm.anchorIndex = sm.leadIndex = sm.selectedIndex = length;
+      scrollIntoViewAndMakeEditable(length);
     });
   }
 
   navigateTo(parentId, editNewFolderInList);
 }
 
 /**
  * Scrolls the list item into view and makes it editable.
  * @param {number} index The index of the item to make editable.
  */
 function scrollIntoViewAndMakeEditable(index) {
   bmm.list.scrollIndexIntoView(index);
   // onscroll is now dispatched asynchronously so we have to postpone
   // the rest.
   setTimeout(function() {
     var item = bmm.list.getListItemByIndex(index);
     if (item)
       item.editing = true;
   }, 0);
 }
 
 /**
  * Adds a page to the current folder. This is called by the
  * add-new-bookmark-command handler.
  */
 function addPage() {
   var parentId = computeParentFolderForNewItem();
+  var newIndex = '';
+  var selectedItem = bmm.list.selectedItem;
+  function editNewBookmark() {
+    if (selectedItem && document.activeElement != bmm.tree) {
+      if (!bmm.isFolder(selectedItem))
+         newIndex = 1 + bmm.list.dataModel.indexOf(selectedItem);
+   }
 
-  function editNewBookmark() {
     var fakeNode = {
       title: '',
       url: '',
       parentId: parentId,
+      index: newIndex,
       id: 'new'
     };
     var dataModel = bmm.list.dataModel;
     var length = dataModel.length;
+    if (newIndex != '' && newIndex <= length)
+        length = newIndex;

[Bernhard Bauer, 2014/12/22 11:58:20]

Same here; this is not really a length anymore, it's an insertion index.

[Deepak, 2014/12/23 04:27:47]

Done.

     dataModel.splice(length, 0, fakeNode);
     var sm = bmm.list.selectionModel;
     sm.anchorIndex = sm.leadIndex = sm.selectedIndex = length;
     scrollIntoViewAndMakeEditable(length);
   };
 
   navigateTo(parentId, editNewBookmark);
 }
 
 /**
@@ skipping 388 matching lines @@
 
   cr.ui.FocusOutlineManager.forDocument(document);
   initializeSplitter();
   bmm.addBookmarkModelListeners();
   dnd.init(selectItemsAfterUserAction);
   bmm.tree.reload();
 }
 
 initializeBookmarkManager();
 })();