Issue 795433003: [turbofan] Handle collisions properly in value numbering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 795433003: [turbofan] Handle collisions properly in value numbering. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Handle collisions properly in value numbering. R=svenpanne@chromium.org Committed: https://crrev.com/788411c334bacafd53aaf78e557c23471e5555a3 Cr-Commit-Position: refs/heads/master@{#25857}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	src/compiler/value-numbering-reducer.cc	View		1 chunk	+26 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Sven Panne

LGTM. As discussed offline, the only chance to make a test case for this would ...

6 years ago (2014-12-17 07:59:52 UTC) #3

Benedikt Meurer

Committed patchset #1 (id:1) manually as 788411c334bacafd53aaf78e557c23471e5555a3 (presubmit successful).

6 years ago (2014-12-17 08:05:43 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-17 10:14:45 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/788411c334bacafd53aaf78e557c23471e5555a3
Cr-Commit-Position: refs/heads/master@{#25857}