Issue 79543009: move SkProcCoeffXfermode unflatten constructor into .cpp, and range-check its mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79543009: move SkProcCoeffXfermode unflatten constructor into .cpp, and range-check its mode (Closed)

Created:
7 years, 1 month ago by reed1

Modified:
7 years, 1 month ago

Reviewers:
sugoi1, sugoi

CC:
skia-review_googlegroups.com, tfarina

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

move SkProcCoeffXfermode unflatten constructor into .cpp, and range-check its mode BUG= Committed: https://code.google.com/p/skia/source/detail?r=12355

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
	M	src/core/SkXfermode.cpp	View		1 chunk	+16 lines, -0 lines	1 comment	Download
	M	src/core/SkXfermode_proccoeff.h	View		2 chunks	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

Committed patchset #1 manually as r12355 (presubmit successful).

7 years, 1 month ago (2013-11-21 21:05:11 UTC) #3

tfarina

7 years, 1 month ago (2013-11-21 23:45:06 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/79543009/diff/1/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/79543009/diff/1/src/core/SkXfermode.cpp#newco...
src/core/SkXfermode.cpp:1346:
SkProcCoeffXfermode::SkProcCoeffXfermode(SkFlattenableReadBuffer& buffer) :
INHERITED(buffer) {
Does SkProcCoeffXfermode deserve its own cpp file?

Expand Messages | Collapse Messages