Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 79543006: Add tests for negative border-image-width and border-image-outset (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add tests for negative border-image-width and border-image-outset BUG=318081 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162531

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Patch Set 3 : nit: elm was misnamed; move getComputedStyle into test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A LayoutTests/fast/borders/border-image-width-negative.html View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/borders/border-image-width-negative-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davve
7 years, 1 month ago (2013-11-21 15:59:29 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/79543006/diff/1/LayoutTests/fast/borders/border-image-width-negative.html File LayoutTests/fast/borders/border-image-width-negative.html (right): https://codereview.chromium.org/79543006/diff/1/LayoutTests/fast/borders/border-image-width-negative.html#newcode4 LayoutTests/fast/borders/border-image-width-negative.html:4: <title>Test that negative border image width values are ...
7 years, 1 month ago (2013-11-21 21:30:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/79543006/60001
7 years, 1 month ago (2013-11-22 08:08:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/79543006/200001
7 years, 1 month ago (2013-11-22 09:20:44 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 10:21:54 UTC) #5
Message was sent while issue was closed.
Change committed as 162531

Powered by Google App Engine
This is Rietveld 408576698