[Hotword] Implement IsHotwordHardwareAvailable() using device types.

[Hotword] Implement IsHotwordHardwareAvailable() using device types.

Adds an additional device type to the chromeos::AudioDevice enum.

BUG=403138
Committed: https://crrev.com/fca3b1544dd63d8ae46300ee07ac91feb4bdd89e
Cr-Commit-Position: refs/heads/master@{#308533}

[rpetterson, 2014-12-12 00:41:27]

rlp@chromium.org changed reviewers:
+ amistry@chromium.org, dgreid@chromium.org, jennyz@chromium.org

[rpetterson, 2014-12-12 00:41:27]

dgreid: overall and using the correct device type

jennyz: audio_device.{cc,h} -- Is that the correct way to add a type for the DSP
and am I checking it correctly?

amistry: hotword_service_factory.cc

Thank you!

[dgreid, 2014-12-12 00:59:44]

This looks like it should work, One possible issue:

Jenny, how can we filter this device from being listed to the user, but still
have it appear in this list.

[jennyz, 2014-12-12 23:22:53]

On 2014/12/12 00:59:44, dgreid wrote:
> This looks like it should work, One possible issue:
> 
> Jenny, how can we filter this device from being listed to the user, but still
> have it appear in this list.

Which chromeos device will have this type of hardware? Either the UI code can
filter out this device by its device type, or, we can add a new attribute for
AudioDevice as is_visible_in_ui_ and sets it be false for this particular type.

[dgreid, 2014-12-12 23:25:24]

On 2014/12/12 23:22:53, jennyz wrote:
> On 2014/12/12 00:59:44, dgreid wrote:
> > This looks like it should work, One possible issue:
> > 
> > Jenny, how can we filter this device from being listed to the user, but
still
> > have it appear in this list.
> 
> Which chromeos device will have this type of hardware? Either the UI code can
> filter out this device by its device type, or, we can add a new attribute for
> AudioDevice as is_visible_in_ui_ and sets it be false for this particular
type.

There will be several upcoming chromebooks with AOKR nodes.  The type will
always be "AOKR", that's probably the righ tthing to filter on.

[rpetterson, 2014-12-12 23:30:46]

On 2014/12/12 23:25:24, dgreid wrote:
> On 2014/12/12 23:22:53, jennyz wrote:
> > On 2014/12/12 00:59:44, dgreid wrote:
> > > This looks like it should work, One possible issue:
> > > 
> > > Jenny, how can we filter this device from being listed to the user, but
> still
> > > have it appear in this list.
> > 
> > Which chromeos device will have this type of hardware? Either the UI code
can
> > filter out this device by its device type, or, we can add a new attribute
for
> > AudioDevice as is_visible_in_ui_ and sets it be false for this particular
> type.
> 
> There will be several upcoming chromebooks with AOKR nodes.  The type will
> always be "AOKR", that's probably the righ tthing to filter on.

Jenny, please let me know which solution you think is best and I will add it to
this CL. Thanks!

[jennyz, 2014-12-13 00:04:50]

On 2014/12/12 23:30:46, rpetterson wrote:
> On 2014/12/12 23:25:24, dgreid wrote:
> > On 2014/12/12 23:22:53, jennyz wrote:
> > > On 2014/12/12 00:59:44, dgreid wrote:
> > > > This looks like it should work, One possible issue:
> > > > 
> > > > Jenny, how can we filter this device from being listed to the user, but
> > still
> > > > have it appear in this list.
> > > 
> > > Which chromeos device will have this type of hardware? Either the UI code
> can
> > > filter out this device by its device type, or, we can add a new attribute
> for
> > > AudioDevice as is_visible_in_ui_ and sets it be false for this particular
> > type.
> > 
> > There will be several upcoming chromebooks with AOKR nodes.  The type will
> > always be "AOKR", that's probably the righ tthing to filter on.
> 
> Jenny, please let me know which solution you think is best and I will add it
to
> this CL. Thanks!

The first approach is simplest, we already filter out the keyboard_mic in this
way, you can just follow.
https://code.google.com/p/chromium/codesearch#chromium/src/ash/system/chromeo...

[jennyz, 2014-12-13 00:05:01]

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:54: if (devices[i].type ==
chromeos::AUDIO_TYPE_AOKR)
By the way, do you know if this device is an input or output device?

[dgreid, 2014-12-13 00:06:11]

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:54: if (devices[i].type ==
chromeos::AUDIO_TYPE_AOKR)
On 2014/12/13 00:05:01, jennyz wrote:
> By the way, do you know if this device is an input or output device? 

always input.

[jennyz, 2014-12-13 00:08:14]

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:54: if (devices[i].type ==
chromeos::AUDIO_TYPE_AOKR)
On 2014/12/13 00:06:11, dgreid wrote:
> On 2014/12/13 00:05:01, jennyz wrote:
> > By the way, do you know if this device is an input or output device? 
> 
> always input.
How about
DCHECK(devices[i].is_input)?

[rpetterson, 2014-12-13 00:13:32]

On 2014/12/13 00:08:14, jennyz wrote:
>
https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
> File chrome/browser/search/hotword_service_factory.cc (right):
> 
>
https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
> chrome/browser/search/hotword_service_factory.cc:54: if (devices[i].type ==
> chromeos::AUDIO_TYPE_AOKR)
> On 2014/12/13 00:06:11, dgreid wrote:
> > On 2014/12/13 00:05:01, jennyz wrote:
> > > By the way, do you know if this device is an input or output device? 
> > 
> > always input.
> How about
> DCHECK(devices[i].is_input)?

Uploaded to include the check and DCHECK.

[jennyz, 2014-12-13 00:17:36]

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:54: if (devices[i].type ==
chromeos::AUDIO_TYPE_AOKR)
On 2014/12/13 00:08:14, jennyz wrote:
> On 2014/12/13 00:06:11, dgreid wrote:
> > On 2014/12/13 00:05:01, jennyz wrote:
> > > By the way, do you know if this device is an input or output device? 
> > 
> > always input.
> How about
> DCHECK(devices[i].is_input)?

I think it makes more sense to DCHECK it is input device here.

https://codereview.chromium.org/795393002/diff/40001/ash/system/chromeos/audi...
File ash/system/chromeos/audio/audio_detailed_view.cc (right):

https://codereview.chromium.org/795393002/diff/40001/ash/system/chromeos/audi...
ash/system/chromeos/audio/audio_detailed_view.cc:122:
DCHECK(devices[i].is_input);
We can skip the DCHECK here, since UI code does not really care if the device is
input or output.

[Anand Mistry (off Chromium), 2014-12-13 00:33:39]

LGTM for hotword_service_factory

[rpetterson, 2014-12-13 00:56:27]

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
File chrome/browser/search/hotword_service_factory.cc (right):

https://codereview.chromium.org/795393002/diff/1/chrome/browser/search/hotwor...
chrome/browser/search/hotword_service_factory.cc:54: if (devices[i].type ==
chromeos::AUDIO_TYPE_AOKR)
On 2014/12/13 00:17:36, jennyz wrote:
> On 2014/12/13 00:08:14, jennyz wrote:
> > On 2014/12/13 00:06:11, dgreid wrote:
> > > On 2014/12/13 00:05:01, jennyz wrote:
> > > > By the way, do you know if this device is an input or output device? 
> > > 
> > > always input.
> > How about
> > DCHECK(devices[i].is_input)?
> 
> I think it makes more sense to DCHECK it is input device here.

Ah, got it. I got the lines confused before. Done.

https://codereview.chromium.org/795393002/diff/40001/ash/system/chromeos/audi...
File ash/system/chromeos/audio/audio_detailed_view.cc (right):

https://codereview.chromium.org/795393002/diff/40001/ash/system/chromeos/audi...
ash/system/chromeos/audio/audio_detailed_view.cc:122:
DCHECK(devices[i].is_input);
On 2014/12/13 00:17:36, jennyz wrote:
> We can skip the DCHECK here, since UI code does not really care if the device
is
> input or output.

Done.

[jennyz, 2014-12-15 18:01:33]

lgtm

[rpetterson, 2014-12-16 00:05:47]

rlp@chromium.org changed reviewers:
+ benwells@chromium.org

[rpetterson, 2014-12-16 00:05:48]

benwells@chromium.org: Please review changes in component_loader_unittest

[benwells, 2014-12-16 01:24:24]

lgtm

[rpetterson, 2014-12-16 04:47:50]

The CQ bit was checked by rlp@chromium.org

[commit-bot: I haz the power, 2014-12-16 04:48:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795393002/180001

[commit-bot: I haz the power, 2014-12-16 05:36:52]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2014-12-16 05:37:33]

Patchset 10 (id:??) landed as
https://crrev.com/fca3b1544dd63d8ae46300ee07ac91feb4bdd89e
Cr-Commit-Position: refs/heads/master@{#308533}