Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: chrome/browser/ui/views/detachable_toolbar_view.h

Issue 795353003: views: Cleanup some things in DetachableToolbarView class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/detachable_toolbar_view.h
diff --git a/chrome/browser/ui/views/detachable_toolbar_view.h b/chrome/browser/ui/views/detachable_toolbar_view.h
index 0b8d2e3ceaf2ce95ebd34a94d216911bcc07e842..bee06e406ae529f43007d7921effa27e4fb4d84f 100644
--- a/chrome/browser/ui/views/detachable_toolbar_view.h
+++ b/chrome/browser/ui/views/detachable_toolbar_view.h
@@ -14,11 +14,6 @@ struct SkRect;
// from the Chrome frame, such as the BookmarkBarView and the Extension shelf.
class DetachableToolbarView : public views::AccessiblePaneView {
public:
- // The color gradient start value close to the edge of the divider.
- static const SkColor kEdgeDividerColor;
- // The color gradient value for the middle of the divider.
- static const SkColor kMiddleDividerColor;
-
DetachableToolbarView() {}
~DetachableToolbarView() override {}
@@ -41,19 +36,6 @@ class DetachableToolbarView : public views::AccessiblePaneView {
const gfx::Point& background_origin,
chrome::HostDesktopType host_desktop_type);
- // Calculate the rect for the content area of the bar/shelf. This is only
- // needed when the bar/shelf is detached from the Chrome frame (otherwise the
- // content area is the whole area of the bar/shelf. When detached, however,
- // only a small round rectangle is for drawing our content on. This calculates
- // how big this area is, where it is located within the shelf and how round
- // the edges should be.
- static void CalculateContentArea(double animation_state,
- double horizontal_padding,
- double vertical_padding,
- SkRect* rect,
- double* roundness,
- views::View* view);
-
// Paint the horizontal border separating the shelf/bar from the toolbar or
// page content according to |at_top| with |color|.
static void PaintHorizontalBorder(gfx::Canvas* canvas,
@@ -61,19 +43,6 @@ class DetachableToolbarView : public views::AccessiblePaneView {
bool at_top,
SkColor color);
- // Paint the background of the content area (the surface behind the
- // bookmarks). |rect| is the rectangle to paint the background within.
- // |roundness| describes the roundness of the corners.
- static void PaintContentAreaBackground(gfx::Canvas* canvas,
- ui::ThemeProvider* theme_provider,
- const SkRect& rect,
- double roundness);
- // Paint the border around the content area (when in detached mode).
- static void PaintContentAreaBorder(gfx::Canvas* canvas,
- ui::ThemeProvider* theme_provider,
- const SkRect& rect,
- double roundness);
-
// Paint a themed gradient divider at location |x|. |height| is the full
// height of the view you want to paint the divider into, not the height of
// the divider. The height of the divider will become:
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/views/detachable_toolbar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698