Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5543)

Unified Diff: chrome/browser/ui/views/detachable_toolbar_view.cc

Issue 795353003: views: Cleanup some things in DetachableToolbarView class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/detachable_toolbar_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/detachable_toolbar_view.cc
diff --git a/chrome/browser/ui/views/detachable_toolbar_view.cc b/chrome/browser/ui/views/detachable_toolbar_view.cc
index 872238d540563b68c40803872018791ce136c000..998cd1bcde2711eabc402ee6783f01267dd2711f 100644
--- a/chrome/browser/ui/views/detachable_toolbar_view.cc
+++ b/chrome/browser/ui/views/detachable_toolbar_view.cc
@@ -14,18 +14,6 @@
#include "ui/gfx/skia_util.h"
#include "ui/views/window/non_client_view.h"
-namespace {
-
-// How round the 'new tab' style bookmarks bar is.
-const int kNewTabBarRoundness = 5;
-
-} // namespace
-
-const SkColor DetachableToolbarView::kEdgeDividerColor =
- SkColorSetRGB(222, 234, 248);
-const SkColor DetachableToolbarView::kMiddleDividerColor =
- SkColorSetRGB(194, 205, 212);
-
// static
void DetachableToolbarView::PaintBackgroundAttachedMode(
gfx::Canvas* canvas,
@@ -36,41 +24,33 @@ void DetachableToolbarView::PaintBackgroundAttachedMode(
canvas->FillRect(bounds,
theme_provider->GetColor(ThemeProperties::COLOR_TOOLBAR));
canvas->TileImageInt(*theme_provider->GetImageSkiaNamed(IDR_THEME_TOOLBAR),
- background_origin.x(), background_origin.y(), bounds.x(),
- bounds.y(), bounds.width(), bounds.height());
+ background_origin.x(),
+ background_origin.y(),
+ bounds.x(),
+ bounds.y(),
+ bounds.width(),
+ bounds.height());
if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH) {
// Ash provides additional lightening at the edges of the toolbar.
gfx::ImageSkia* toolbar_left =
theme_provider->GetImageSkiaNamed(IDR_TOOLBAR_SHADE_LEFT);
canvas->TileImageInt(*toolbar_left,
- bounds.x(), bounds.y(),
- toolbar_left->width(), bounds.height());
+ bounds.x(),
+ bounds.y(),
+ toolbar_left->width(),
+ bounds.height());
gfx::ImageSkia* toolbar_right =
theme_provider->GetImageSkiaNamed(IDR_TOOLBAR_SHADE_RIGHT);
canvas->TileImageInt(*toolbar_right,
- bounds.right() - toolbar_right->width(), bounds.y(),
- toolbar_right->width(), bounds.height());
+ bounds.right() - toolbar_right->width(),
+ bounds.y(),
+ toolbar_right->width(),
+ bounds.height());
}
}
// static
-void DetachableToolbarView::CalculateContentArea(double animation_state,
- double horizontal_padding,
- double vertical_padding,
- SkRect* rect,
- double* roundness,
- views::View* view) {
- // The 0.5 is to correct for Skia's "draw on pixel boundaries"ness.
- rect->set(SkDoubleToScalar(horizontal_padding - 0.5),
- SkDoubleToScalar(vertical_padding - 0.5),
- SkDoubleToScalar(view->width() - horizontal_padding - 0.5),
- SkDoubleToScalar(view->height() - vertical_padding - 0.5));
-
- *roundness = static_cast<double>(kNewTabBarRoundness) * animation_state;
-}
-
-// static
void DetachableToolbarView::PaintHorizontalBorder(gfx::Canvas* canvas,
DetachableToolbarView* view,
bool at_top,
@@ -81,38 +61,6 @@ void DetachableToolbarView::PaintHorizontalBorder(gfx::Canvas* canvas,
}
// static
-void DetachableToolbarView::PaintContentAreaBackground(
- gfx::Canvas* canvas,
- ui::ThemeProvider* theme_provider,
- const SkRect& rect,
- double roundness) {
- SkPaint paint;
- paint.setAntiAlias(true);
- paint.setColor(theme_provider->GetColor(ThemeProperties::COLOR_TOOLBAR));
-
- canvas->sk_canvas()->drawRoundRect(
- rect, SkDoubleToScalar(roundness), SkDoubleToScalar(roundness), paint);
-}
-
-// static
-void DetachableToolbarView::PaintContentAreaBorder(
- gfx::Canvas* canvas,
- ui::ThemeProvider* theme_provider,
- const SkRect& rect,
- double roundness) {
- SkPaint border_paint;
- border_paint.setColor(
- theme_provider->GetColor(ThemeProperties::COLOR_NTP_HEADER));
- border_paint.setStyle(SkPaint::kStroke_Style);
- border_paint.setAlpha(96);
- border_paint.setAntiAlias(true);
-
- canvas->sk_canvas()->drawRoundRect(
- rect, SkDoubleToScalar(roundness), SkDoubleToScalar(roundness),
- border_paint);
-}
-
-// static
void DetachableToolbarView::PaintVerticalDivider(gfx::Canvas* canvas,
int x,
int height,
« no previous file with comments | « chrome/browser/ui/views/detachable_toolbar_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698