Issue 795353003: views: Cleanup some things in DetachableToolbarView class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 795353003: views: Cleanup some things in DetachableToolbarView class. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

views: Cleanup some things in DetachableToolbarView class. * Remove unused methods. * Move SkColor constants into BookmarkBarView (solo user). BUG=None R=sky@chromium.org Committed: https://crrev.com/dd811e66bb623d2f80bbe85ad43396eeafa6f6a7 Cr-Commit-Position: refs/heads/master@{#308095}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -100 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/detachable_toolbar_view.h	View	3 chunks	+0 lines, -31 lines	0 comments	Download
M	chrome/browser/ui/views/detachable_toolbar_view.cc	View	3 chunks	+14 lines, -66 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795353003/1

6 years ago (2014-12-12 15:37:11 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-12 16:23:28 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dd811e66bb623d2f80bbe85ad43396eeafa6f6a7
Cr-Commit-Position: refs/heads/master@{#308095}