downloads: prevent "Clear all" from removing in progress downloads

chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_reader.h"
 #include "base/prefs/pref_service.h"
 #include "base/values.h"
 #include "chrome/browser/history/download_row.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/webui/downloads_dom_handler.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/mock_download_item.h"
+#include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_utils.h"
 
 namespace {
 
 // Reads |right_json| into a ListValue |left_list|; returns true if all
 // key-value pairs in in all dictionaries in |right_list| are also in the
 // corresponding dictionary in |left_list|. Ignores keys in dictionaries in
 // |left_list| that are not in the corresponding dictionary in |right_list|.
 bool ListMatches(base::ListValue* left_list, const std::string& right_json) {
   scoped_ptr<base::Value> right_value(base::JSONReader::Read(right_json));
@@ skipping 19 matching lines @@
   return true;
 }
 
 // A |DownloadsDOMHandler| that doesn't use a real WebUI object, but is real in
 // all other respects.
 class MockDownloadsDOMHandler : public DownloadsDOMHandler {
  public:
   explicit MockDownloadsDOMHandler(content::DownloadManager* dlm)
     : DownloadsDOMHandler(dlm),
       waiting_list_(false),
-      waiting_updated_(false) {
+      waiting_updated_(false),
+      manager_(nullptr) {
   }
   ~MockDownloadsDOMHandler() override {}
 
   base::ListValue* downloads_list() { return downloads_list_.get(); }
   base::ListValue* download_updated() { return download_updated_.get(); }
 
   void WaitForDownloadsList() {
     if (downloads_list_.get())
       return;
     base::AutoReset<bool> reset_waiting(&waiting_list_, true);
     content::RunMessageLoop();
   }
 
   void WaitForDownloadUpdated() {
     if (download_updated_.get())
       return;
     base::AutoReset<bool> reset_waiting(&waiting_updated_, true);
     content::RunMessageLoop();
   }
 
   void ForceSendCurrentDownloads() {
     ScheduleSendCurrentDownloads();
   }
 
   void reset_downloads_list() { downloads_list_.reset(); }
   void reset_download_updated() { download_updated_.reset(); }
 
+  void set_manager(content::DownloadManager* manager) { manager_ = manager; }
+
  protected:
   content::WebContents* GetWebUIWebContents() override { return NULL; }
 
   void CallDownloadsList(const base::ListValue& downloads) override {
     downloads_list_.reset(downloads.DeepCopy());
     if (waiting_list_) {
       content::BrowserThread::PostTask(content::BrowserThread::UI,
                                        FROM_HERE,
                                        base::MessageLoop::QuitClosure());
     }
   }
 
   void CallDownloadUpdated(const base::ListValue& download) override {
     download_updated_.reset(download.DeepCopy());
     if (waiting_updated_) {
       content::BrowserThread::PostTask(content::BrowserThread::UI,
                                        FROM_HERE,
                                        base::MessageLoop::QuitClosure());
     }
   }
 
+  content::DownloadManager* GetMainNotifierManager() override {
+    return manager_ ? manager_ : DownloadsDOMHandler::GetMainNotifierManager();
+  }
+
  private:
   scoped_ptr<base::ListValue> downloads_list_;
   scoped_ptr<base::ListValue> download_updated_;
   bool waiting_list_;
   bool waiting_updated_;
+  content::DownloadManager* manager_;  // weak.
 
   DISALLOW_COPY_AND_ASSIGN(MockDownloadsDOMHandler);
 };
 
 }  // namespace
 
 class DownloadsDOMHandlerTest : public InProcessBrowserTest {
  public:
   DownloadsDOMHandlerTest() {}
 
@@ skipping 96 matching lines @@
   ASSERT_EQ(1, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
 
   mock_handler_->reset_downloads_list();
   browser()->profile()->GetPrefs()->SetBoolean(
       prefs::kAllowDeletingBrowserHistory, true);
   mock_handler_->HandleRemove(&item);
   mock_handler_->WaitForDownloadsList();
   EXPECT_EQ(0, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
 }
 
+IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest, ClearAllSkipsInProgress) {
+  content::MockDownloadManager manager;
+  mock_handler_->set_manager(&manager);
+
+  content::MockDownloadItem item;
+  EXPECT_CALL(item, GetState()).WillRepeatedly(
+      testing::Return(content::DownloadItem::IN_PROGRESS));
+  EXPECT_CALL(item, UpdateObservers()).Times(0);
+
+  std::vector<content::DownloadItem*> items;
+  items.push_back(&item);
+  EXPECT_CALL(manager, GetAllDownloads(testing::_)).WillOnce(
+      testing::SetArgPointee<0>(items));
+
+  mock_handler_->HandleClearAll(NULL);
+}
+
 // Tests that DownloadsDOMHandler detects new downloads and relays them to the
 // renderer.
 // crbug.com/159390: This test fails when daylight savings time ends.
 IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest, DownloadsRelayed) {
   DownloadAnItem();
 
   mock_handler_->WaitForDownloadUpdated();
   ASSERT_EQ(1, static_cast<int>(mock_handler_->download_updated()->GetSize()));
   EXPECT_TRUE(ListMatches(
       mock_handler_->download_updated(),
@@ skipping 15 matching lines @@
 // TODO(benjhayden): Test incognito, both downloads_list() and that on-record
 // calls can't access off-record items.
 
 // TODO(benjhayden): Test that bad download ids incoming from the javascript are
 // dropped on the floor.
 
 // TODO(benjhayden): Test that IsTemporary() downloads are not shown.
 
 // TODO(benjhayden): Test that RemoveObserver is called on all download items,
 // including items that crossed IsTemporary() and back.