downloads: prevent "Clear all" from removing in progress downloads

chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_reader.h"
 #include "base/prefs/pref_service.h"
 #include "base/values.h"
 #include "chrome/browser/history/download_row.h"
@@ skipping 114 matching lines @@
     browser()->profile()->GetPrefs()->SetFilePath(
         prefs::kDownloadDefaultDirectory,
         downloads_directory_.path());
     CHECK(test_server()->Start());
   }
 
   content::DownloadManager* download_manager() {
     return content::BrowserContext::GetDownloadManager(browser()->profile());
   }
 
-  void DownloadAnItem() {
+  void DownloadAnItem(bool in_progress) {
     GURL url = test_server()->GetURL("files/downloads/image.jpg");
     std::vector<GURL> url_chain;
     url_chain.push_back(url);
     base::Time current(base::Time::Now());
     download_manager()->CreateDownloadItem(
         1, // id
         base::FilePath(FILE_PATH_LITERAL("/path/to/file")),
         base::FilePath(FILE_PATH_LITERAL("/path/to/file")),
         url_chain,
         GURL(std::string()),
         "application/octet-stream",
         "application/octet-stream",
         current,
         current,
         std::string(),
         std::string(),
         128,
         128,
-        content::DownloadItem::COMPLETE,
+        in_progress ? content::DownloadItem::IN_PROGRESS :
+                      content::DownloadItem::COMPLETE,
         content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
         content::DOWNLOAD_INTERRUPT_REASON_NONE,
         false);
 
     mock_handler_->WaitForDownloadsList();
     ASSERT_EQ(1, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
+    std::string state = in_progress ? "IN_PROGRESS" : "COMPLETE";
     EXPECT_TRUE(ListMatches(
         mock_handler_->downloads_list(),
         "[{\"file_externally_removed\": false,"
         "  \"file_name\": \"file\","
         "  \"id\": \"1\","
         "  \"otr\": false,"
         "  \"since_string\": \"Today\","
-        "  \"state\": \"COMPLETE\","
+        "  \"state\": \"" + state + "\","
         "  \"total\": 128}]"));
   }
 
  protected:
   scoped_ptr<MockDownloadsDOMHandler> mock_handler_;
 
  private:
   base::ScopedTempDir downloads_directory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadsDOMHandlerTest);
 };
 
 // Tests removing all items, both when prohibited and when allowed.
 IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest, RemoveAll) {
-  DownloadAnItem();
+  DownloadAnItem(false);
 
   mock_handler_->reset_downloads_list();
   browser()->profile()->GetPrefs()->SetBoolean(
       prefs::kAllowDeletingBrowserHistory, false);
   mock_handler_->HandleClearAll(NULL);
   // Attempting to clear all shouldn't do anything when deletion is disabled.
   mock_handler_->ForceSendCurrentDownloads();
   mock_handler_->WaitForDownloadsList();
   ASSERT_EQ(1, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
 
   mock_handler_->reset_downloads_list();
   browser()->profile()->GetPrefs()->SetBoolean(
       prefs::kAllowDeletingBrowserHistory, true);
   mock_handler_->HandleClearAll(NULL);
   mock_handler_->WaitForDownloadsList();
   EXPECT_EQ(0, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
 }
 
+// Tests removing all items, both when prohibited and when allowed.
+IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest, RemoveAllIgnoresInProgress) {
+  DownloadAnItem(true);
+
+  mock_handler_->reset_downloads_list();
+  mock_handler_->HandleClearAll(NULL);
+  mock_handler_->ForceSendCurrentDownloads();
+  mock_handler_->WaitForDownloadsList();
+  EXPECT_EQ(1, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
+
+  // Cancel the download so Chrome can shut down.
+  download_manager()->GetDownload(1)->Cancel(false);
+}
+
 // Tests removing one item, both when prohibited and when allowed.
 IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest, RemoveOneItem) {
-  DownloadAnItem();
+  DownloadAnItem(false);
   base::ListValue item;
   item.AppendString("1");
 
   mock_handler_->reset_downloads_list();
   browser()->profile()->GetPrefs()->SetBoolean(
       prefs::kAllowDeletingBrowserHistory, false);
   mock_handler_->HandleRemove(&item);
   // Removing an item only sends the new download list if anything was actually
   // removed, so force it.
   mock_handler_->ForceSendCurrentDownloads();
   mock_handler_->WaitForDownloadsList();
   ASSERT_EQ(1, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
 
   mock_handler_->reset_downloads_list();
   browser()->profile()->GetPrefs()->SetBoolean(
       prefs::kAllowDeletingBrowserHistory, true);
   mock_handler_->HandleRemove(&item);
   mock_handler_->WaitForDownloadsList();
   EXPECT_EQ(0, static_cast<int>(mock_handler_->downloads_list()->GetSize()));
 }
 
 // Tests that DownloadsDOMHandler detects new downloads and relays them to the
 // renderer.
 // crbug.com/159390: This test fails when daylight savings time ends.
 IN_PROC_BROWSER_TEST_F(DownloadsDOMHandlerTest, DownloadsRelayed) {
-  DownloadAnItem();
+  DownloadAnItem(false);
 
   mock_handler_->WaitForDownloadUpdated();
   ASSERT_EQ(1, static_cast<int>(mock_handler_->download_updated()->GetSize()));
   EXPECT_TRUE(ListMatches(
       mock_handler_->download_updated(),
       "[{\"file_externally_removed\": true,"
       "  \"id\": \"1\"}]"));
 
   mock_handler_->reset_downloads_list();
   browser()->profile()->GetPrefs()->SetBoolean(
@@ skipping 10 matching lines @@
 // TODO(benjhayden): Test incognito, both downloads_list() and that on-record
 // calls can't access off-record items.
 
 // TODO(benjhayden): Test that bad download ids incoming from the javascript are
 // dropped on the floor.
 
 // TODO(benjhayden): Test that IsTemporary() downloads are not shown.
 
 // TODO(benjhayden): Test that RemoveObserver is called on all download items,
 // including items that crossed IsTemporary() and back.