Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/omnibox/omnibox_log.h

Issue 795343002: Omnibox Watcher: Don't Flag Incidents that are Paste+Enter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grt's comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/omnibox/omnibox_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/omnibox/omnibox_log.h
diff --git a/chrome/browser/omnibox/omnibox_log.h b/chrome/browser/omnibox/omnibox_log.h
index 08216bcea7db4f5f685128e9f5dce2cc83effcca..b0f7f661410a6f22de23f2527b6eb01f93a9c411 100644
--- a/chrome/browser/omnibox/omnibox_log.h
+++ b/chrome/browser/omnibox/omnibox_log.h
@@ -26,6 +26,7 @@ struct OmniboxLog {
bool is_popup_open,
size_t selected_index,
bool is_paste_and_go,
+ bool last_action_was_paste,
SessionID::id_type tab_id,
metrics::OmniboxEventProto::PageClassification
current_page_classification,
@@ -56,6 +57,10 @@ struct OmniboxLog {
// (The codebase refers to both these types as paste-and-go.)
bool is_paste_and_go;
+ // True if the user's last action was a PASTE or if (somehow) the user is
Peter Kasting 2014/12/12 21:44:27 Nit: Why is PASTE capitalized?
Mark P 2014/12/12 22:07:21 No good reason. Fixed.
+ // still in the act of pasting.
+ bool last_action_was_paste;
+
// ID of the tab the selected autocomplete suggestion was opened in.
// Set to -1 if we haven't yet determined the destination tab.
SessionID::id_type tab_id;
« no previous file with comments | « no previous file | chrome/browser/omnibox/omnibox_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698