Omnibox Watcher: Don't Flag Incidents that are Paste+Enter

chrome/browser/omnibox/omnibox_log.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_
 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_
 
 #include <stddef.h>
 
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "components/metrics/proto/omnibox_event.pb.h"
 #include "components/metrics/proto/omnibox_input_type.pb.h"
 #include "components/omnibox/autocomplete_provider.h"
 #include "components/sessions/session_id.h"
 
 class AutocompleteResult;
 
 // The data to log (via the metrics service) when the user selects an item from
 // the omnibox popup.
 struct OmniboxLog {
   OmniboxLog(
       const base::string16& text,
       bool just_deleted_text,
       metrics::OmniboxInputType::Type input_type,
       bool is_popup_open,
       size_t selected_index,
       bool is_paste_and_go,
+      bool last_action_was_paste,
       SessionID::id_type tab_id,
       metrics::OmniboxEventProto::PageClassification
           current_page_classification,
       base::TimeDelta elapsed_time_since_user_first_modified_omnibox,
       size_t completed_length,
       base::TimeDelta elapsed_time_since_last_change_to_default_match,
       const AutocompleteResult& result);
   ~OmniboxLog();
 
   // The user's input text in the omnibox.
@@ skipping 10 matching lines @@
   bool is_popup_open;
 
   // The index of the item selected in the dropdown list.  Set to 0 if the
   // dropdown is closed (and therefore there is only one implicit suggestion).
   size_t selected_index;
 
   // True if this is a paste-and-search or paste-and-go omnibox interaction.
   // (The codebase refers to both these types as paste-and-go.)
   bool is_paste_and_go;
 
+  // True if the last action was a PASTE or if (somehow) we're still in the

[grt (UTC plus 2), 2014/12/12 14:43:49]

nit: rewrite comment without "we're"

[Mark P, 2014/12/12 20:44:33]

Done.

+  // act of pasting.
+  bool last_action_was_paste;
+
   // ID of the tab the selected autocomplete suggestion was opened in.
   // Set to -1 if we haven't yet determined the destination tab.
   SessionID::id_type tab_id;
 
   // The type of page (e.g., new tab page, regular web page) that the
   // user was viewing before going somewhere with the omnibox.
   metrics::OmniboxEventProto::PageClassification current_page_classification;
 
   // The amount of time since the user first began modifying the text
   // in the omnibox.  If at some point after modifying the text, the
@@ skipping 22 matching lines @@
   // Result set.
   const AutocompleteResult& result;
 
   // Diagnostic information from providers.  See
   // AutocompleteController::AddProvidersInfo() and
   // AutocompleteProvider::AddProviderInfo() above.
   ProvidersInfo providers_info;
 };
 
 #endif  // CHROME_BROWSER_OMNIBOX_OMNIBOX_LOG_H_