Omnibox Watcher: Don't Flag Incidents that are Paste+Enter

Omnibox Watcher: Don't Flag Incidents that are Paste+Enter

The code currently excludes paste-and-go operations.  It should probably
also exclude paste+enter operations; these are effectively equivalent.

TODO before submitting: test interactively

BUG=
TBR=bauerb@chromium.org,rogerta@chromium.org
bauerb for change to chrome/browser/android/omnibox/autocomplete_controller_android.cc
rogerta for change to chrome/browser/rlz/rlz_unittest.cc

Committed: https://crrev.com/c281fb257d2acdd247b0692380d084863e2dd462
Cr-Commit-Position: refs/heads/master@{#308233}

Committed: https://crrev.com/0dc8fbf38d87a17b5ec0bfe8249d69341122686a
Cr-Commit-Position: refs/heads/master@{#308378}

[Mark P, 2014-12-11 23:07:34]

mpearson@chromium.org changed reviewers:
+ grt@chromium.org, pkasting@chromium.org

[Mark P, 2014-12-11 23:10:40]

pkasting: please review chrome/browser/omnibox/... and
chrome/browser/ui/omnibox/omnibox_edit_model.cc
grt: please review
chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.cc

thanks,
mark

[grt (UTC plus 2), 2014-12-12 14:43:49]

lgtm with nits

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/omnibox/o...
File chrome/browser/omnibox/omnibox_log.h (right):

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/omnibox/o...
chrome/browser/omnibox/omnibox_log.h:60: // True if the last action was a PASTE
or if (somehow) we're still in the
nit: rewrite comment without "we're"

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/ui/omnibo...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/ui/omnibo...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:759: paste_state_ != NONE,
nit:
      paste_state_ != NONE,  // last_action_was_paste

[Mark P, 2014-12-12 20:44:33]

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/omnibox/o...
File chrome/browser/omnibox/omnibox_log.h (right):

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/omnibox/o...
chrome/browser/omnibox/omnibox_log.h:60: // True if the last action was a PASTE
or if (somehow) we're still in the
On 2014/12/12 14:43:49, grt wrote:
> nit: rewrite comment without "we're"

Done.

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/ui/omnibo...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/795343002/diff/20001/chrome/browser/ui/omnibo...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:759: paste_state_ != NONE,
On 2014/12/12 14:43:49, grt wrote:
> nit:
>       paste_state_ != NONE,  // last_action_was_paste

Done.

[grt (UTC plus 2), 2014-12-12 20:47:55]

lgtm++

[Peter Kasting, 2014-12-12 21:44:28]

LGTM

https://codereview.chromium.org/795343002/diff/40001/chrome/browser/omnibox/o...
File chrome/browser/omnibox/omnibox_log.h (right):

https://codereview.chromium.org/795343002/diff/40001/chrome/browser/omnibox/o...
chrome/browser/omnibox/omnibox_log.h:60: // True if the user's last action was a
PASTE or if (somehow) the user is
Nit: Why is PASTE capitalized?

[Mark P, 2014-12-12 22:07:21]

https://codereview.chromium.org/795343002/diff/40001/chrome/browser/omnibox/o...
File chrome/browser/omnibox/omnibox_log.h (right):

https://codereview.chromium.org/795343002/diff/40001/chrome/browser/omnibox/o...
chrome/browser/omnibox/omnibox_log.h:60: // True if the user's last action was a
PASTE or if (somehow) the user is
On 2014/12/12 21:44:27, Peter Kasting wrote:
> Nit: Why is PASTE capitalized?

No good reason.  Fixed.

[Mark P, 2014-12-12 22:07:24]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:07:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795343002/60001

[commit-bot: I haz the power, 2014-12-12 22:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:40:33]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Mark P, 2014-12-12 23:12:33]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-12-12 23:13:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795343002/80001

[commit-bot: I haz the power, 2014-12-13 00:25:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-13 00:25:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2014-12-13 00:59:37]

TBR bauerb@chromium.org for chrome/browser/android OWNERS since the change there
is purely to track an interface change.

[grt (UTC plus 2), 2014-12-13 00:59:48]

grt@chromium.org changed reviewers:
+ bauerb@chromium.org

[grt (UTC plus 2), 2014-12-13 01:00:05]

On 2014/12/13 00:59:37, grt wrote:
> TBR mailto:bauerb@chromium.org for chrome/browser/android OWNERS since the
change there
> is purely to track an interface change.

This time with mail sent to bauerb@chromium.org.

[grt (UTC plus 2), 2014-12-13 01:00:09]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2014-12-13 01:01:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795343002/80001

[commit-bot: I haz the power, 2014-12-13 03:09:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-13 03:09:57]

Patchset 5 (id:??) landed as
https://crrev.com/c281fb257d2acdd247b0692380d084863e2dd462
Cr-Commit-Position: refs/heads/master@{#308233}

[Mark P, 2014-12-13 05:53:46]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/800983005/ by mpearson@chromium.org.

The reason for reverting is: causes crashes in official builders.
../../chrome/browser/rlz/rlz_unittest.cc:240:14:error: no matching constructor
for initialization of 'OmniboxLog'
  OmniboxLog dummy(base::string16(), false, metrics::OmniboxInputType::INVALID,
             ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../chrome/browser/omnibox/omnibox_log.h:22:3: note: candidate constructor not
viable: requires 13 arguments, but 12 were provided
  OmniboxLog(
  ^
../../chrome/browser/omnibox/omnibox_log.h:21:8: note: candidate constructor
(the implicit copy constructor) not viable: requires 1 argument, but 12 were
provided
struct OmniboxLog {
       ^
1 error generated.
.

[Mark P, 2014-12-15 17:50:08]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-12-15 17:51:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795343002/100001

[commit-bot: I haz the power, 2014-12-15 18:54:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-12-15 18:55:19]

Patchset 6 (id:??) landed as
https://crrev.com/0dc8fbf38d87a17b5ec0bfe8249d69341122686a
Cr-Commit-Position: refs/heads/master@{#308378}