Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chromeos/accelerometer/accelerometer_reader.h

Issue 795333002: Refactor AccelerometerReader to provide an Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix athena build Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/ash_init.cc ('k') | chromeos/accelerometer/accelerometer_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/accelerometer/accelerometer_reader.h
diff --git a/chromeos/accelerometer/accelerometer_reader.h b/chromeos/accelerometer/accelerometer_reader.h
index 3cf473f72cf44346c83714a3a9f2fdea6f0e4861..ff1e5adc1b556cd540d8b7e6ddd70f129b6aa4d4 100644
--- a/chromeos/accelerometer/accelerometer_reader.h
+++ b/chromeos/accelerometer/accelerometer_reader.h
@@ -45,18 +45,24 @@ class CHROMEOS_EXPORT AccelerometerReader {
typedef base::RefCountedData<char[12]> Reading;
// An interface to receive data from the AccelerometerReader.
- class Delegate {
+ class Observer {
public:
- virtual ~Delegate() {}
-
- virtual void HandleAccelerometerUpdate(
+ virtual void OnAccelerometerUpdated(
const ui::AccelerometerUpdate& update) = 0;
+
+ protected:
+ virtual ~Observer() {}
};
- AccelerometerReader(scoped_refptr<base::TaskRunner> blocking_task_runner,
- Delegate* delegate);
+ AccelerometerReader();
~AccelerometerReader();
+ void Initialize(scoped_refptr<base::TaskRunner> blocking_task_runner);
+
+ // Add/Remove observers.
+ void AddObserver(Observer* observer);
+ void RemoveObserver(Observer* observer);
+
private:
// Dispatched when initialization is complete. If |success|, |configuration|
// provides the details of the detected accelerometer.
@@ -74,15 +80,14 @@ class CHROMEOS_EXPORT AccelerometerReader {
// The task runner to use for blocking tasks.
scoped_refptr<base::TaskRunner> task_runner_;
- // A weak pointer to the delegate to send accelerometer readings to.
- Delegate* delegate_;
-
// The last seen accelerometer data.
ui::AccelerometerUpdate update_;
// The accelerometer configuration.
scoped_refptr<Configuration> configuration_;
+ ObserverList<Observer, true> observers_;
+
base::WeakPtrFactory<AccelerometerReader> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(AccelerometerReader);
« no previous file with comments | « chrome/browser/ui/ash/ash_init.cc ('k') | chromeos/accelerometer/accelerometer_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698