Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chromeos/accelerometer/accelerometer_reader.cc

Issue 795333002: Refactor AccelerometerReader to provide an Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix athena build Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/accelerometer/accelerometer_reader.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/accelerometer/accelerometer_reader.h" 5 #include "chromeos/accelerometer/accelerometer_reader.h"
6 6
7 #include <string>
8
7 #include "base/bind.h" 9 #include "base/bind.h"
8 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
9 #include "base/location.h" 11 #include "base/location.h"
10 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
11 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
13 #include "base/strings/stringprintf.h" 15 #include "base/strings/stringprintf.h"
14 #include "base/task_runner.h" 16 #include "base/task_runner.h"
15 #include "base/task_runner_util.h" 17 #include "base/task_runner_util.h"
16 #include "base/threading/sequenced_worker_pool.h" 18 #include "base/threading/sequenced_worker_pool.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 for (int j = 0; j < 3; ++j) { 176 for (int j = 0; j < 3; ++j) {
175 scale[i][j] = 0; 177 scale[i][j] = 0;
176 index[i][j] = -1; 178 index[i][j] = -1;
177 } 179 }
178 } 180 }
179 } 181 }
180 182
181 AccelerometerReader::ConfigurationData::~ConfigurationData() { 183 AccelerometerReader::ConfigurationData::~ConfigurationData() {
182 } 184 }
183 185
184 AccelerometerReader::AccelerometerReader( 186 AccelerometerReader::AccelerometerReader()
185 scoped_refptr<base::TaskRunner> blocking_task_runner, 187 : configuration_(new AccelerometerReader::Configuration()),
186 AccelerometerReader::Delegate* delegate)
187 : task_runner_(blocking_task_runner),
188 delegate_(delegate),
189 configuration_(new AccelerometerReader::Configuration()),
190 weak_factory_(this) { 188 weak_factory_(this) {
191 DCHECK(task_runner_.get()); 189 }
192 DCHECK(delegate_); 190
191 AccelerometerReader::~AccelerometerReader() {
192 }
193
194 void AccelerometerReader::Initialize(
195 scoped_refptr<base::TaskRunner> blocking_task_runner) {
196 DCHECK(blocking_task_runner.get());
197 task_runner_ = blocking_task_runner;
193 // Asynchronously detect and initialize the accelerometer to avoid delaying 198 // Asynchronously detect and initialize the accelerometer to avoid delaying
194 // startup. 199 // startup.
195 base::PostTaskAndReplyWithResult(task_runner_.get(), FROM_HERE, 200 base::PostTaskAndReplyWithResult(
201 task_runner_.get(), FROM_HERE,
196 base::Bind(&DetectAndReadAccelerometerConfiguration, configuration_), 202 base::Bind(&DetectAndReadAccelerometerConfiguration, configuration_),
197 base::Bind(&AccelerometerReader::OnInitialized, 203 base::Bind(&AccelerometerReader::OnInitialized,
198 weak_factory_.GetWeakPtr(), configuration_)); 204 weak_factory_.GetWeakPtr(), configuration_));
199 } 205 }
200 206
201 AccelerometerReader::~AccelerometerReader() { 207 void AccelerometerReader::AddObserver(Observer* observer) {
208 observers_.AddObserver(observer);
209 }
210
211 void AccelerometerReader::RemoveObserver(Observer* observer) {
212 observers_.RemoveObserver(observer);
202 } 213 }
203 214
204 void AccelerometerReader::OnInitialized( 215 void AccelerometerReader::OnInitialized(
205 scoped_refptr<AccelerometerReader::Configuration> configuration, 216 scoped_refptr<AccelerometerReader::Configuration> configuration,
206 bool success) { 217 bool success) {
207 if (success) 218 if (success)
208 TriggerRead(); 219 TriggerRead();
209 } 220 }
210 221
211 void AccelerometerReader::TriggerRead() { 222 void AccelerometerReader::TriggerRead() {
(...skipping 22 matching lines...) Expand all
234 245
235 int16* values = reinterpret_cast<int16*>(reading->data); 246 int16* values = reinterpret_cast<int16*>(reading->data);
236 update_.Set(static_cast<ui::AccelerometerSource>(i), 247 update_.Set(static_cast<ui::AccelerometerSource>(i),
237 values[configuration_->data.index[i][0]] * 248 values[configuration_->data.index[i][0]] *
238 configuration_->data.scale[i][0], 249 configuration_->data.scale[i][0],
239 values[configuration_->data.index[i][1]] * 250 values[configuration_->data.index[i][1]] *
240 configuration_->data.scale[i][1], 251 configuration_->data.scale[i][1],
241 values[configuration_->data.index[i][2]] * 252 values[configuration_->data.index[i][2]] *
242 configuration_->data.scale[i][2]); 253 configuration_->data.scale[i][2]);
243 } 254 }
244 delegate_->HandleAccelerometerUpdate(update_); 255 FOR_EACH_OBSERVER(Observer, observers_, OnAccelerometerUpdated(update_));
245 } 256 }
246 257
247 // Trigger another read after the current sampling delay. 258 // Trigger another read after the current sampling delay.
248 base::MessageLoop::current()->PostDelayedTask( 259 base::MessageLoop::current()->PostDelayedTask(
249 FROM_HERE, 260 FROM_HERE,
250 base::Bind(&AccelerometerReader::TriggerRead, 261 base::Bind(&AccelerometerReader::TriggerRead,
251 weak_factory_.GetWeakPtr()), 262 weak_factory_.GetWeakPtr()),
252 base::TimeDelta::FromMilliseconds(kDelayBetweenReadsMs)); 263 base::TimeDelta::FromMilliseconds(kDelayBetweenReadsMs));
253 } 264 }
254 265
255 } // namespace chromeos 266 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/accelerometer/accelerometer_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698